Bug 219561 - Reduce memory copying in MultiChannelResampler::provideInputForChannel()
Summary: Reduce memory copying in MultiChannelResampler::provideInputForChannel()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 219560
Blocks:
  Show dependency treegraph
 
Reported: 2020-12-04 17:12 PST by Chris Dumez
Modified: 2020-12-07 08:30 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.56 KB, patch)
2020-12-04 17:15 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-12-04 17:12:51 PST
Reduce memory copying in MultiChannelResampler::provideInputForChannel() by using the passed-in buffer as memory for the first channel in the AudioBus.
This way we avoid having to memcpy() the data for the first channel.
Comment 1 Chris Dumez 2020-12-04 17:15:51 PST
Created attachment 415478 [details]
Patch
Comment 2 Chris Dumez 2020-12-07 08:29:48 PST
Comment on attachment 415478 [details]
Patch

Clearing flags on attachment: 415478

Committed r270505: <https://trac.webkit.org/changeset/270505>
Comment 3 Chris Dumez 2020-12-07 08:29:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-12-07 08:30:19 PST
<rdar://problem/72048111>