Bug 219560 - Simplify audio resampling code
Summary: Simplify audio resampling code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 219561
  Show dependency tree / graph
 
Reported: 2020-12-04 16:17 PST by Chris Dumez
Modified: 2020-12-04 17:28 PST (History)
10 users (show)

See Also:

Attachments
Patch (30.10 KB, patch)
2020-12-04 16:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (30.21 KB, patch)
2020-12-04 16:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-12-04 16:17:56 PST 
Simplify audio resampling code.
Comment 1 Chris Dumez 2020-12-04 16:37:40 PST 
Created attachment 415474 [details]
Patch
Comment 2 Darin Adler 2020-12-04 16:43:38 PST 
Comment on attachment 415474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415474&action=review

> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:124
> +    if (AudioSourceProvider* provider = mediaElement().audioSourceProvider())

I would've used auto here. And I noticed you did use it in a similar case below.

> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:172
> +    if (m_multiChannelResampler.get()) {

I don’t think "get()" is needed here.
Comment 3 Chris Dumez 2020-12-04 16:45:57 PST 
Created attachment 415475 [details]
Patch
Comment 4 EWS 2020-12-04 17:27:11 PST 
Committed r270468: <https://trac.webkit.org/changeset/270468>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415475 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-04 17:28:16 PST 
<rdar://problem/72000044>