RESOLVED FIXED219560
Simplify audio resampling code 
https://bugs.webkit.org/show_bug.cgi?id=219560
Summary Simplify audio resampling code
Chris Dumez
Reported 2020-12-04 16:17:56 PST
Simplify audio resampling code.
Attachments
Patch (30.10 KB, patch)
2020-12-04 16:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (30.21 KB, patch)
2020-12-04 16:45 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-12-04 16:37:40 PST
Created attachment 415474 [details] Patch
Darin Adler
Comment 2 2020-12-04 16:43:38 PST
Comment on attachment 415474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415474&action=review > Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:124 > + if (AudioSourceProvider* provider = mediaElement().audioSourceProvider()) I would've used auto here. And I noticed you did use it in a similar case below. > Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:172 > + if (m_multiChannelResampler.get()) { I don’t think "get()" is needed here.
Chris Dumez
Comment 3 2020-12-04 16:45:57 PST
Created attachment 415475 [details] Patch
EWS
Comment 4 2020-12-04 17:27:11 PST
Committed r270468: <https://trac.webkit.org/changeset/270468> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415475 [details].
Radar WebKit Bug Importer
Comment 5 2020-12-04 17:28:16 PST
<rdar://problem/72000044>
Note You need to log in before you can comment on or make changes to this bug.