[WTF] Avoid JSONValue::create with raw string falling to bool overload

[Lauro Moura]

[WTF] Avoid JSONValue::create with raw string falling to bool overload

[Lauro Moura]

Created attachment 415278 [details]
Patch

[Lauro Moura]

Comment on attachment 415278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415278&action=review

> Source/WTF/wtf/JSONValues.h:81
> +    static Ref<Value> create(T) = delete;

If `create(T)` is too strict, it could use `create(T*)` instead, to avoid only the pointer conversions.

[Adrian Perez]

Comment on attachment 415278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415278&action=review

>> Source/WTF/wtf/JSONValues.h:81
>> +    static Ref<Value> create(T) = delete;
> 
> If `create(T)` is too strict, it could use `create(T*)` instead, to avoid only the pointer conversions.

I think this is fine, and forbidding all possible implicit conversions is
probably even a good thing, thus ensuring that only the provided create()
factory functions are ever used.

[EWS]

Committed r270391: <https://trac.webkit.org/changeset/270391>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415278 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71930497>