Bug 218686 – Web Inspector: ensure that `JSON::ArrayOf<T>` doesn't allow `addItem` to be called with a type other than `T`

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Right now, `JSON::ArrayOf<T>` always has `addItem` overloads for `int`, `double`, `String`, and `Ref<T>` (even when `T` is not a `JSON::Value`).  This means that I could have a `JSON::ArrayOf<int>` and call `addItem(42.0)` or `addItem("foo"_s)` and it would work.  We should prevent that.

[Devin Rousso]

Created attachment 413529 [details]
Patch

[Devin Rousso]

Created attachment 413563 [details]
Patch

[EWS Watchlist]

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

[Blaze Burg]

Comment on attachment 413563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413563&action=review

r=me

> Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator_templates.py:142
> +    static NeverDestroyed<DispatchMap> dispatchMap = DispatchMap({

🤯

> Source/JavaScriptCore/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:342
> +    static NeverDestroyed<DispatchMap> dispatchMap = DispatchMap({

Ugh, you are the best, Devin! This is so much nicer.

[EWS]

Committed r269757: <https://trac.webkit.org/changeset/269757>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413563 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71345351>