RESOLVED FIXED 21942
[Transforms] Various absoluteRect methods need to be made transform-aware
https://bugs.webkit.org/show_bug.cgi?id=21942
Summary [Transforms] Various absoluteRect methods need to be made transform-aware
Simon Fraser (smfr)
Reported 2008-10-28 18:12:46 PDT
The following methods don't take transforms into account, and should (or should be changed or removed): absoluteContentBox() absoluteOutlineBox() absoluteRects() absoluteBoundingBoxRect() absoluteClippedOverflowRect() getAbsoluteRepaintRectWithOutline() computeAbsoluteRepaintRect()
Attachments
WIP patch (54.85 KB, patch)
2008-11-10 18:22 PST, Simon Fraser (smfr)
no flags
Patch, changelog (60.44 KB, patch)
2008-11-11 18:08 PST, Simon Fraser (smfr)
hyatt: review+
Simon Fraser (smfr)
Comment 1 2008-11-10 18:22:58 PST
Created attachment 25037 [details] WIP patch
Simon Fraser (smfr)
Comment 2 2008-11-11 18:08:45 PST
Created attachment 25082 [details] Patch, changelog This also includes a fix for bug 18557, the inspector highlight.
Dave Hyatt
Comment 3 2008-11-12 13:22:16 PST
Comment on attachment 25082 [details] Patch, changelog r=me
Simon Fraser (smfr)
Comment 4 2008-11-12 15:44:15 PST
Committed r38346 M WebCore/GNUmakefile.am A WebCore/platform/graphics/FloatQuad.cpp M WebCore/platform/graphics/AffineTransform.h A WebCore/platform/graphics/FloatQuad.h M WebCore/platform/graphics/AffineTransform.cpp M WebCore/inspector/InspectorController.cpp M WebCore/rendering/RenderSVGTSpan.cpp M WebCore/rendering/RenderObject.cpp M WebCore/rendering/RenderSVGTextPath.cpp M WebCore/rendering/RenderTableCell.cpp M WebCore/rendering/RenderBox.h M WebCore/rendering/RenderSVGContainer.cpp M WebCore/rendering/RenderSVGInlineText.h M WebCore/rendering/RenderObject.h M WebCore/rendering/RenderPath.cpp M WebCore/rendering/RenderSVGInlineText.cpp M WebCore/rendering/RenderSVGContainer.h M WebCore/rendering/RenderText.cpp M WebCore/rendering/RenderSVGText.h M WebCore/rendering/RenderSVGTSpan.h M WebCore/rendering/RenderInline.cpp M WebCore/rendering/RenderSVGTextPath.h M WebCore/rendering/RenderBox.cpp M WebCore/rendering/RenderSVGHiddenContainer.cpp M WebCore/rendering/RenderInline.h M WebCore/rendering/RenderView.cpp M WebCore/rendering/RenderContainer.cpp M WebCore/rendering/RenderSVGHiddenContainer.h M WebCore/rendering/RenderSVGImage.cpp M WebCore/rendering/RenderSVGText.cpp M WebCore/rendering/RenderSVGRoot.h M WebCore/rendering/RenderView.h M WebCore/rendering/RenderContainer.h M WebCore/rendering/RenderPath.h M WebCore/rendering/RenderSVGRoot.cpp M WebCore/rendering/RenderSVGImage.h M WebCore/rendering/RenderText.h M WebCore/rendering/RenderTableCell.h M WebCore/WebCore.xcodeproj/project.pbxproj M WebCore/WebCore.pro M WebCore/ChangeLog M WebCore/WebCore.vcproj/WebCore.vcproj M WebCore/WebCoreSources.bkl r38346 = aacf70eaac35eb2876221d42a341158aa25de806 (trunk)
Note You need to log in before you can comment on or make changes to this bug.