The API exposed by AxisScrollSnapOffsets is written with a one-dimensional set of scroll snap offsets in mind. Moving this code to ScrollSnapOffsetsInfo is the first step toward rewriting the API to deal with ScrollSnapOffsetsInfo, which abstracts away the implementation details of scroll snap offsets.
Created attachment 415011 [details]
Created attachment 415013 [details]
Comment on attachment 415013 [details]
This patch looks good. I see a lot of opportunities to modernize the moved code and use constexpr, range for-loops, etc etc. I think I've seen different code styling for templates in other code.
Thanks very much for the review. I would definitely like to continue improving this code.
Committed r270390: <https://trac.webkit.org/changeset/270390>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 415013 [details].