Bug 219273 - Have scroll-snap support code use ScrollSnapOffsetsInfo as much as possible
Summary: Have scroll-snap support code use ScrollSnapOffsetsInfo as much as possible
Status: RESOLVED DUPLICATE of bug 145157
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on: 219345
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-24 03:46 PST by Martin Robinson
Modified: 2021-01-20 04:43 PST (History)
18 users (show)

See Also:

Attachments
Patch (83.82 KB, patch)
2020-11-26 06:54 PST, Martin Robinson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (87.85 KB, patch)
2020-11-26 07:24 PST, Martin Robinson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (88.19 KB, patch)
2020-11-26 08:03 PST, Martin Robinson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (88.60 KB, patch)
2020-11-26 08:32 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2020-11-24 03:46:07 PST 
In the future, WebKit will not use two vectors of offsets to store snap offset info. In order to prepare for this, it can instead pass around the pre-existing SnapOffsetsInfo which abstracts away how snap points are stored. This bug tracks using SnapOffsetsInfo to a greater extent and removing references to "horizontal snap offsets" and "vertical snap offsets."
Comment 2 Martin Robinson 2020-11-26 06:54:26 PST 
Created attachment 414902 [details]
Patch
Comment 3 Martin Robinson 2020-11-26 07:24:31 PST 
Created attachment 414904 [details]
Patch
Comment 4 Martin Robinson 2020-11-26 08:03:04 PST 
Created attachment 414905 [details]
Patch
Comment 5 Martin Robinson 2020-11-26 08:32:21 PST 
Created attachment 414906 [details]
Patch
Comment 6 Martin Robinson 2020-11-27 06:27:33 PST 
Comment on attachment 414906 [details]
Patch

I'm going to split these changes up into smaller pieces that are easier to review. Sorry for the noise.
Comment 7 Radar WebKit Bug Importer 2020-12-01 03:47:19 PST 
<rdar://problem/71844999>
Comment 8 Martin Robinson 2021-01-20 04:42:21 PST 
I'm going to close this metabug in favor of using bug 145157 as the metabug, just to make chasing these a bit easier.
Comment 9 Martin Robinson 2021-01-20 04:42:37 PST 

*** This bug has been marked as a duplicate of bug 145157 ***