Bug 219067 - [Concurrent display lists] Add a way for display lists to partially replay
Summary: [Concurrent display lists] Add a way for display lists to partially replay
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 218614 219091 219097
  Show dependency tree / graph
 
Reported: 2020-11-17 21:03 PST by Wenson Hsieh
Modified: 2020-11-19 12:30 PST (History)
6 users (show)

See Also:

Attachments
Patch (34.21 KB, patch)
2020-11-17 21:47 PST, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix debug builds (30.48 KB, patch)
2020-11-17 23:12 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rebase on trunk (30.51 KB, patch)
2020-11-17 23:22 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Slightly simpler approach (28.76 KB, patch)
2020-11-18 14:42 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-11-17 21:03:55 PST 
SSIA
Comment 1 Wenson Hsieh 2020-11-17 21:47:01 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-11-17 23:12:10 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-11-17 23:22:49 PST Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2020-11-18 14:42:55 PST 
Created attachment 414486 [details]
Slightly simpler approach
Comment 5 Simon Fraser (smfr) 2020-11-18 16:25:50 PST 
Comment on attachment 414486 [details]
Slightly simpler approach

View in context: https://bugs.webkit.org/attachment.cgi?id=414486&action=review

> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:154
> +        if (destination.isAccelerated())
> +            static_cast<AcceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList);
> +        else
> +            static_cast<UnacceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList);

This is sad-making.
Comment 6 Tim Horton 2020-11-18 16:47:37 PST 
Yeah, it's the same problem in a bunch of places (but, hopefully we can fix them all simultaneously).
Comment 7 Wenson Hsieh 2020-11-18 16:49:18 PST 
Comment on attachment 414486 [details]
Slightly simpler approach

View in context: https://bugs.webkit.org/attachment.cgi?id=414486&action=review

>> Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp:154
>> +            static_cast<UnacceleratedRemoteImageBuffer&>(destination).submitDisplayList(*displayList);
> 
> This is sad-making.

Yeah, it's not great :(

I wanted to try to cast to a RemoteImageBuffer, but that's a templated class. I think that ideally, RemoteRenderingBackend would know about the RemoteImageBuffers it can paint into (instead of always digging it up from the resource cache).
Comment 8 EWS 2020-11-18 17:21:12 PST 
Committed r270002: <https://trac.webkit.org/changeset/270002>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414486 [details].
Comment 9 Radar WebKit Bug Importer 2020-11-18 17:22:19 PST 
<rdar://problem/71563985>