Bug 219014 - [macOS] Only extend access to the AppleSNBFBUserClient IOKit class if the GPU Process is not used
Summary: [macOS] Only extend access to the AppleSNBFBUserClient IOKit class if the GPU...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 219012
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-16 16:47 PST by Brent Fulgham
Modified: 2020-12-03 16:31 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2020-11-16 19:57 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2020-12-03 09:37 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-11-16 16:47:42 PST 
Although we originally thought this was needed for H.264 decoding, testing shows that this class is never used in WebKit flows, and is not needed. We should remove it.
Comment 1 Brent Fulgham 2020-11-16 16:47:56 PST 
<rdar://problem/70463873>
Comment 2 Brent Fulgham 2020-11-16 19:57:22 PST 
Created attachment 414302 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2020-11-16 19:58:18 PST 
<rdar://problem/71470589>
Comment 4 Brent Fulgham 2020-11-16 20:06:19 PST 
This is actually:
<rdar://problem/70463873>
Comment 5 EWS 2020-11-17 09:57:07 PST 
Committed r269911: <https://trac.webkit.org/changeset/269911>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414302 [details].
Comment 6 Brent Fulgham 2020-11-19 17:19:30 PST 
I rolled this change out as part of this <https://trac.webkit.org/changeset/270061>.

Instead, we will dynamically extend to WebContent when needed (eventually never), and grant access in GPU Process.
Comment 7 Brent Fulgham 2020-12-03 09:37:33 PST 
Created attachment 415306 [details]
Patch
Comment 8 Per Arne Vollan 2020-12-03 09:51:16 PST 
Comment on attachment 415306 [details]
Patch

R=me.
Comment 9 EWS 2020-12-03 16:31:48 PST 
Committed r270418: <https://trac.webkit.org/changeset/270418>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415306 [details].