Bug 219014 - [macOS] Remove access to the unused AppleSNBFBUserClient IOKit class
Summary: [macOS] Remove access to the unused AppleSNBFBUserClient IOKit class
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2020-11-16 16:47 PST by Brent Fulgham
Modified: 2020-11-19 17:19 PST (History)
4 users (show)

See Also:

Patch (2.79 KB, patch)
2020-11-16 19:57 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-11-16 16:47:42 PST
Although we originally thought this was needed for H.264 decoding, testing shows that this class is never used in WebKit flows, and is not needed. We should remove it.
Comment 1 Brent Fulgham 2020-11-16 16:47:56 PST
Comment 2 Brent Fulgham 2020-11-16 19:57:22 PST
Created attachment 414302 [details]
Comment 3 Radar WebKit Bug Importer 2020-11-16 19:58:18 PST
Comment 4 Brent Fulgham 2020-11-16 20:06:19 PST
This is actually:
Comment 5 EWS 2020-11-17 09:57:07 PST
Committed r269911: <https://trac.webkit.org/changeset/269911>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414302 [details].
Comment 6 Brent Fulgham 2020-11-19 17:19:30 PST
I rolled this change out as part of this <https://trac.webkit.org/changeset/270061>.

Instead, we will dynamically extend to WebContent when needed (eventually never), and grant access in GPU Process.