Although we originally thought this was needed for H.264 decoding, testing shows that this class is never used in WebKit flows, and is not needed. We should remove it.
Created attachment 414290 [details]
Committed r269890: <https://trac.webkit.org/changeset/269890>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 414290 [details].
Reopening to attach new patch.
Created attachment 414300 [details]
Ignore the above.
It looks like the changes in https://trac.webkit.org/changeset/269890/webkit
has broken platform/mac/media/encrypted-media/fps-generateRequest.html on Catalina wk2
@@ -6,6 +6,6 @@
RUN(session = keys.createSession())
EXPECTED (session != 'null') OK
RUN(promise = session.generateRequest("sinf", initData))
-Promise resolved OK
+Promise rejected FAIL
END OF TEST
(In reply to Truitt Savell from comment #7)
> It looks like the changes in https://trac.webkit.org/changeset/269890/webkit
> has broken platform/mac/media/encrypted-media/fps-generateRequest.html on
> Catalina wk2
I'll look into it now. I'm building a local root on Catalina to test. These tests do pass on Big Sur, so I might just need to tighten the version check.
I cannot reproduce this failure on a Release Intel MacBook Pro on Catalina, or an Intel MacPro on Big Sur. Perhaps this is hardware-specific.
Given that some Intel CPU's require this access to support encrypted media playback, we should extend this dynamically to WebContent if we are not using the GPU Process, and always grant it in the GPU Process.
Committed r270061: <https://trac.webkit.org/changeset/270061>
(In reply to Brent Fulgham from comment #11)
> Committed r270061: <https://trac.webkit.org/changeset/270061>
I rolled out this bug in the above patch.
Created attachment 415254 [details]
Created attachment 415257 [details]
Created attachment 415258 [details]
Comment on attachment 415258 [details]
Patch was reviewed by Eric Carlson. I'm flagging an updated patch that he reviewed online with me.
Committed r270381: <https://trac.webkit.org/changeset/270381>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 415258 [details].