NEW 218972
Use downcast instead of static_cast for casting GraphicsContextGL -> GraphicsContextGLOpenGL
https://bugs.webkit.org/show_bug.cgi?id=218972
Summary Use downcast instead of static_cast for casting GraphicsContextGL -> Graphics...
Kimmo Kinnunen
Reported 2020-11-16 01:31:14 PST
Use downcast instead of static_cast for casting GraphicsContextGL to GraphicsContextGLOpenGL This is to be done only if removing !USE(ANGLE) from WebGL implementation is not possible. https://bugs.webkit.org/show_bug.cgi?id=218333#c9 Simon Fraser (smfr) 2020-11-13 10:38:15 PST >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1790 >> + static_cast<GraphicsContextGLOpenGL*>(m_context.get())->compressedTexImage2D(target, level, internalformat, width, height, >I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast<> for all these casts.
Attachments
Radar WebKit Bug Importer
Comment 1 2020-11-26 03:17:37 PST
Note You need to log in before you can comment on or make changes to this bug.