Final refactor for WebGL implementation to use only GraphicsContextGL
Created attachment 412637 [details]
Created attachment 412643 [details]
Would be a bit easier to review if the unrelated whitespace changes were not part of the change.
Created attachment 414015 [details]
Created attachment 414021 [details]
Created attachment 414028 [details]
Created attachment 414030 [details]
Comment on attachment 414030 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=414030&action=review
> + static_cast<GraphicsContextGLOpenGL*>(m_context.get())->compressedTexImage2D(target, level, internalformat, width, height,
I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast<> for all these casts.
Tools/Scripts/svn-apply failed to apply attachment 414030 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Created attachment 414201 [details]
(In reply to Simon Fraser (smfr) from comment #9)
> I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast<> for
> all these casts.
I filed this as bug 218972, so it doesn't block landing this one. IIUC, this is landable given the r+?
I'd rather first try to remove the code-paths altogether. They're a bit inconvenient to edit as in Apple env we don't compile these at all.
Committed r269850: <https://trac.webkit.org/changeset/269850>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 414201 [details].