RESOLVED FIXED 218877
Update ANGLE 2020-11-12 
https://bugs.webkit.org/show_bug.cgi?id=218877
Summary Update ANGLE 2020-11-12
James Darpinian
Reported 2020-11-12 16:58:35 PST
Update ANGLE 2020-11-12
Attachments
Patch (17.65 MB, patch)
2020-11-12 17:05 PST, James Darpinian 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.68 MB, patch)
2020-11-16 16:31 PST, James Darpinian 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.68 MB, patch)
2020-11-16 16:56 PST, James Darpinian 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.68 MB, patch)
2020-11-17 15:12 PST, James Darpinian 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.68 MB, patch)
2020-11-17 16:14 PST, James Darpinian 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.68 MB, patch)
2020-11-19 15:46 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Patch (17.69 MB, patch)
2020-11-19 15:50 PST, James Darpinian 		kbr: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.49 MB, patch)
2020-11-20 12:07 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-11-12 17:05:51 PST
Created attachment 413986 [details] Patch
EWS Watchlist
Comment 2 2020-11-12 17:08:29 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
James Darpinian
Comment 3 2020-11-16 16:31:02 PST
Created attachment 414291 [details] Patch
James Darpinian
Comment 4 2020-11-16 16:56:38 PST
Created attachment 414294 [details] Patch
Radar WebKit Bug Importer
Comment 5 2020-11-16 18:20:28 PST
<rdar://problem/71468200>
James Darpinian
Comment 6 2020-11-17 15:12:03 PST
Created attachment 414390 [details] Patch
James Darpinian
Comment 7 2020-11-17 16:14:28 PST
Created attachment 414394 [details] Patch
James Darpinian
Comment 8 2020-11-19 15:46:04 PST
Created attachment 414630 [details] Patch
James Darpinian
Comment 9 2020-11-19 15:50:22 PST
Created attachment 414631 [details] Patch
James Darpinian
Comment 10 2020-11-19 18:29:22 PST
This is ready. Assuming it passes EWS, please CQ+ if the review looks good. I am off tomorrow.
Kenneth Russell
Comment 11 2020-11-20 10:10:11 PST
Comment on attachment 414631 [details] Patch Great work James improving the tooling around these rolls and completing this big one! Reviewed changes.diff in detail - looks very good, only a couple of diffs relative to upstream at this point. r+ / cq+
EWS
Comment 12 2020-11-20 10:44:31 PST
commit-queue failed to commit attachment 414631 [details] to WebKit repository.
Kenneth Russell
Comment 13 2020-11-20 11:08:58 PST
Comment on attachment 414631 [details] Patch CQ claimed the patch wasn't marked cq+. Trying again.
EWS
Comment 14 2020-11-20 11:41:05 PST
commit-queue failed to commit attachment 414631 [details] to WebKit repository.
James Darpinian
Comment 15 2020-11-20 12:06:52 PST
Ah, tab characters. I can remove those.
James Darpinian
Comment 16 2020-11-20 12:07:28 PST
Created attachment 414704 [details] Patch
EWS
Comment 17 2020-11-20 12:58:25 PST
Committed r270129: <https://trac.webkit.org/changeset/270129> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414704 [details].
Ryan Haddad
Comment 18 2020-11-30 15:43:46 PST
Reverted r270129, r270194, and r270258 for reason: r270129 broke macCatalyst build Committed r270272: <https://trac.webkit.org/changeset/270272>
James Darpinian
Comment 19 2020-11-30 16:34:36 PST
Sorry for the breakage. Is it possible for me to test the maccatalyst build? I don't see a public EWS bot for it and I don't see a way to build it locally.
Kenneth Russell
Comment 20 2020-12-03 13:21:44 PST
Dean helped reland these three patches in: Re-landing r270129, r270194, and r270258. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@270351 268f45cc-cd09-0410-ab3c-d52691b4dbfc http://trac.webkit.org/changeset/270351 (doesn't load in any reasonable period of time) Thank you Dean for taking care of this!
Note You need to log in before you can comment on or make changes to this bug.