Bug 218822 - [build.webkit.org] Replace status with www in master.cfg
Summary: [build.webkit.org] Replace status with www in master.cfg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-11 13:37 PST by Aakash Jain
Modified: 2020-11-12 09:42 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.17 KB, patch)
2020-11-12 08:00 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-11 13:37:30 PST
We are planning to upgrade build.webkit.org to latest buildbot. In Buildbot 0.9 onwards, WebStatus class is gone, and replaced by the new www functionality.

Reference: http://docs.buildbot.net/2.8.4/manual/upgrading/0.9-upgrade.html#web-status
"The most prominent change is that the existing WebStatus class is now gone, replaced by the new www functionality. Thus an html.WebStatus entry in c['status'] should be removed and replaced with configuration in c['www’]`"
Comment 1 Aakash Jain 2020-11-11 13:39:46 PST
This is similar to <rdar://problem/32560308>
Comment 2 Aakash Jain 2020-11-11 13:40:00 PST
<rdar://problem/35211240>
Comment 3 Aakash Jain 2020-11-12 08:00:30 PST
Created attachment 413935 [details]
Patch
Comment 4 Aakash Jain 2020-11-12 08:02:05 PST
Authentication and authorization will be re-implemented separately in https://bugs.webkit.org/show_bug.cgi?id=218823
Comment 5 Jonathan Bedard 2020-11-12 08:54:49 PST
Comment on attachment 413935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413935&action=review

> Tools/CISupport/build-webkit-org/master_buildbot2.cfg:-34
> -                                  changecommentlink=(r"(https://bugs\.webkit\.org/show_bug\.cgi\?id=|webkit\.org/b/)(\d+)", r"https://bugs.webkit.org/show_bug.cgi?id=\2"),

Seems to me that not all of these options are going replaced, is that accurate?
Comment 6 Aakash Jain 2020-11-12 09:15:42 PST
c[‘status’] is completely gone in new buildbot.
Authentication and authorization will be re-implemented separately in https://bugs.webkit.org/show_bug.cgi?id=218823
Comment 7 EWS 2020-11-12 09:42:13 PST
Committed r269735: <https://trac.webkit.org/changeset/269735>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413935 [details].