Bug 218819 - [build.webkit.org] replace c['slavePortnum'] with c['protocols'] in master_buildbot2.cfg
Summary: [build.webkit.org] replace c['slavePortnum'] with c['protocols'] in master_bu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-11 13:13 PST by Aakash Jain
Modified: 2020-11-12 09:04 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2020-11-12 06:25 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-11 13:13:05 PST
We are planning to upgrade build.webkit.org to latest buildbot. In Buildbot 0.9 onwards, Configuration key c['slavePortnum'] is deprecated in favor of c['protocols']['pb']['port']. we should replace c['slavePortnum'] with c['protocols’].

Reference: http://docs.buildbot.net/1.1.0/manual/worker-transition.html#buildmasterconfig-changes
Comment 1 Aakash Jain 2020-11-11 13:13:21 PST
This is similar to <rdar://problem/32560364>.
Comment 2 Aakash Jain 2020-11-12 06:25:11 PST
Created attachment 413930 [details]
Patch
Comment 3 EWS 2020-11-12 09:03:25 PST
Committed r269733: <https://trac.webkit.org/changeset/269733>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413930 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-12 09:04:18 PST
<rdar://problem/71328901>