Bug 218818 – [build.webkit.org] Remove obsolete buildHorizon, eventHorizon and logHorizon properties from master_buildbot2.cfg

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

In latest buildbot, buildHorizon, eventHorizon and logHorizon properties are not supported anymore. We should instead use JanitorConfigurator.

Reference: http://docs.buildbot.net/1.1.0/manual/installation/nine-upgrade.html#data-lifetime


Attempt to use these properties result in following warnings:
ConfigWarning: [0.9.0 and later] NOTE: `buildHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator
ConfigWarning: [0.9.0 and later] NOTE: `eventHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator
ConfigWarning: [0.9.0 and later] NOTE: `logHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator

[Aakash Jain]

This is similar to <rdar://problem/32555413>.

[Aakash Jain]

Created attachment 413926 [details]
Patch

[Jonathan Bedard]

Comment on attachment 413926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413926&action=review

> Tools/CISupport/build-webkit-org/master_buildbot2.cfg:-42
> -c['buildHorizon'] = 1000

What were we using these for and why are they no longer required?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> What were we using these for and why are they no longer required?
These were required only for old buildbot. This file is for new buildbot.

[Jonathan Bedard]

(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > What were we using these for and why are they no longer required?
> These were required only for old buildbot. This file is for new buildbot.

Are they implicitly defined somewhere now? Or something we can't set? buildHorizon sounds like something we would still want to use in some capacity, no?

[Aakash Jain]

Will be configuring Janitor in https://bugs.webkit.org/show_bug.cgi?id=218817

[EWS]

Committed r269736: <https://trac.webkit.org/changeset/269736>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413926 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71330610>