Bug 218818 - [build.webkit.org] Remove obsolete buildHorizon, eventHorizon and logHorizon properties from master_buildbot2.cfg
Summary: [build.webkit.org] Remove obsolete buildHorizon, eventHorizon and logHorizon ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-11 13:03 PST by Aakash Jain
Modified: 2020-11-12 09:46 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.13 KB, patch)
2020-11-12 04:42 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-11 13:03:05 PST
In latest buildbot, buildHorizon, eventHorizon and logHorizon properties are not supported anymore. We should instead use JanitorConfigurator.

Reference: http://docs.buildbot.net/1.1.0/manual/installation/nine-upgrade.html#data-lifetime


Attempt to use these properties result in following warnings:
ConfigWarning: [0.9.0 and later] NOTE: `buildHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator
ConfigWarning: [0.9.0 and later] NOTE: `eventHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator
ConfigWarning: [0.9.0 and later] NOTE: `logHorizon` is deprecated and ignored They are replaced by util.JanitorConfigurator
Comment 1 Aakash Jain 2020-11-11 13:10:44 PST
This is similar to <rdar://problem/32555413>.
Comment 2 Aakash Jain 2020-11-12 04:42:32 PST
Created attachment 413926 [details]
Patch
Comment 3 Jonathan Bedard 2020-11-12 08:45:12 PST
Comment on attachment 413926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413926&action=review

> Tools/CISupport/build-webkit-org/master_buildbot2.cfg:-42
> -c['buildHorizon'] = 1000

What were we using these for and why are they no longer required?
Comment 4 Aakash Jain 2020-11-12 08:55:14 PST
(In reply to Jonathan Bedard from comment #3)
> What were we using these for and why are they no longer required?
These were required only for old buildbot. This file is for new buildbot.
Comment 5 Jonathan Bedard 2020-11-12 09:06:04 PST
(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > What were we using these for and why are they no longer required?
> These were required only for old buildbot. This file is for new buildbot.

Are they implicitly defined somewhere now? Or something we can't set? buildHorizon sounds like something we would still want to use in some capacity, no?
Comment 6 Aakash Jain 2020-11-12 09:13:45 PST
Will be configuring Janitor in https://bugs.webkit.org/show_bug.cgi?id=218817
Comment 7 EWS 2020-11-12 09:44:16 PST
Committed r269736: <https://trac.webkit.org/changeset/269736>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413926 [details].
Comment 8 Radar WebKit Bug Importer 2020-11-12 09:46:09 PST
<rdar://problem/71330610>