RESOLVED FIXED 21881
PlatformString.h should include HashMap.h explicitly 
https://bugs.webkit.org/show_bug.cgi?id=21881
Summary PlatformString.h should include HashMap.h explicitly
Aaron Boodman
Reported 2008-10-24 22:21:28 PDT
PlatformString does not rely on HashMap, but it pulls in kjs/identifier.h, which does. Because of this difference, files using PlatformString sometimes end up breaking in non-JSC builds when they don't directly include HashMap.h. In https://bugs.webkit.org/show_bug.cgi?id=21839, Darin Adler suggested fixing this by explicitly including HashMap in PlatformString.
Attachments
PlatformString.h (1.11 KB, patch)
2008-10-24 22:26 PDT, Aaron Boodman 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aaron Boodman
Comment 1 2008-10-24 22:26:10 PDT
Created attachment 24669 [details] PlatformString.h
Alexey Proskuryakov
Comment 2 2008-10-25 02:49:20 PDT
Did you mean to mark this for review? You can mark a patch for review by clicking Edit button to the right of it, and setting the flag to "?".
Aaron Boodman
Comment 3 2008-10-25 08:42:29 PDT
(In reply to comment #2) > Did you mean to mark this for review? You can mark a patch for review by > clicking Edit button to the right of it, and setting the flag to "?". Yes, thanks. Fixed that.
Darin Adler
Comment 4 2008-10-27 14:22:30 PDT
Comment on attachment 24669 [details] PlatformString.h r=me
Timothy Hatcher
Comment 5 2008-10-30 22:29:16 PDT
Landed in r38023.
Note You need to log in before you can comment on or make changes to this bug.