RESOLVED FIXED 21839
SVGAnimatedTemplate needs HashMap.h included explicitly 
https://bugs.webkit.org/show_bug.cgi?id=21839
Summary SVGAnimatedTemplate needs HashMap.h included explicitly
Dimitri Glazkov (Google)
Reported 2008-10-23 14:01:52 PDT
... because otherwise it may or not be included, depending on the value of USE(JSC)
Attachments
SVGAnimatedTemplate.h (838 bytes, patch)
2008-10-23 14:02 PDT, Dimitri Glazkov (Google) 		darin: review+
DetailsFormatted DiffDiff
Updated ChangeLog entry (793 bytes, patch)
2008-10-23 14:16 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2008-10-23 14:02:38 PDT
Created attachment 24616 [details] SVGAnimatedTemplate.h
Darin Adler
Comment 2 2008-10-23 14:09:28 PDT
Comment on attachment 24616 [details] SVGAnimatedTemplate.h Change Log needs to have your name, not just dglazkov, in the header. Also, you should remove the "WARNING: NO TEST CASES ADDED OR CHANGED" if you don't need any tests and add a link to the bug. It saves the committer time if you do those things right. The reason this isn't needed for JSC platforms is that PlatformString.h includes <kjs/identifier.h> which ends up including HashMap.h. To avoid making ourselves crazy, we might just want to add a HashMap.h include to PlatformString.h to eliminate this difference. r=me, as is
Dimitri Glazkov (Google)
Comment 3 2008-10-23 14:16:09 PDT
Created attachment 24618 [details] Updated ChangeLog entry Apologies about mis-formatted log entry. Updated.
Eric Seidel (no email)
Comment 4 2008-10-27 13:08:03 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/svg/SVGAnimatedTemplate.h Committed r37900
Note You need to log in before you can comment on or make changes to this bug.