Bug 218805 – [build.webkit.org] Update RunWebKitTests step for new buildbot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We are planning to upgrade build.webkit.org to latest Buildbot. We should update RunWebKitTests as per new Buildbot, e.g.:
use logobserver instead of cmd.logs['stdio'].getText()
use getResultSummary instead of getText/getText2

Also we should take this opportunity to switch to logobserver.LineConsumerLogObserver which is more efficient in processing large logs than logobserver.BufferLogObserver.

[Aakash Jain]

Created attachment 413826 [details]
Patch

[Aakash Jain]

(In reply to Aakash Jain from comment #1)
> Created attachment 413826 [details]
> Patch
Most of this code is copied from code written by Dean in another repository.

[Jonathan Bedard]

Comment on attachment 413826 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413826&action=review

> Tools/ChangeLog:10
> +        (RunWebKitTests):

Can we populate this changelog with a bit more information?

> Tools/CISupport/build-webkit-org/steps.py:48
> +    logobserver = lambda: None

Were we not using the log observer previously? Or does that option not exist for buildbot 0.8?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> > Tools/CISupport/build-webkit-org/steps.py:48
> > +    logobserver = lambda: None
> 
> Were we not using the log observer previously? Or does that option not exist for buildbot 0.8?
Yeah, Buildbot 0.8 didn't had this logobserver module.

[Aakash Jain]

Created attachment 413829 [details]
Patch

[EWS]

Committed r269689: <https://trac.webkit.org/changeset/269689>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413829 [details].

[Radar WebKit Bug Importer]

<rdar://problem/71288809>

[Dean Johnson]

Looks good to me; unofficial r+.