We are planning to upgrade build.webkit.org to latest Buildbot. We should update RunWebKitTests as per new Buildbot, e.g.:
use logobserver instead of cmd.logs['stdio'].getText()
use getResultSummary instead of getText/getText2
Also we should take this opportunity to switch to logobserver.LineConsumerLogObserver which is more efficient in processing large logs than logobserver.BufferLogObserver.
Created attachment 413826 [details]
(In reply to Aakash Jain from comment #1)
> Created attachment 413826 [details]
Most of this code is copied from code written by Dean in another repository.
Comment on attachment 413826 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=413826&action=review
> + (RunWebKitTests):
Can we populate this changelog with a bit more information?
> + logobserver = lambda: None
Were we not using the log observer previously? Or does that option not exist for buildbot 0.8?
(In reply to Jonathan Bedard from comment #3)
> > Tools/CISupport/build-webkit-org/steps.py:48
> > + logobserver = lambda: None
> Were we not using the log observer previously? Or does that option not exist for buildbot 0.8?
Yeah, Buildbot 0.8 didn't had this logobserver module.
Created attachment 413829 [details]
Committed r269689: <https://trac.webkit.org/changeset/269689>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 413829 [details].
Looks good to me; unofficial r+.