WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
218759
[build.webkit.org] Update ExtractTestResults step for new buildbot
https://bugs.webkit.org/show_bug.cgi?id=218759
Summary
[build.webkit.org] Update ExtractTestResults step for new buildbot
Aakash Jain
Reported
2020-11-10 09:21:39 PST
We are planning to upgrade build.webkit.org to latest Buildbot. ExtractTestResults step uses few things which behaves differently in new buildbot (e.g.: self.build.getProperties().render() returns deferred instead of string). We should update the step accordingly.
Attachments
Patch
(33.30 KB, patch)
2020-11-10 09:32 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
Patch
(1.27 KB, patch)
2020-11-17 08:06 PST
,
Aakash Jain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2020-11-10 09:32:38 PST
Created
attachment 413708
[details]
Patch
EWS
Comment 2
2020-11-10 11:19:26 PST
Committed
r269633
: <
https://trac.webkit.org/changeset/269633
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 413708
[details]
.
Radar WebKit Bug Importer
Comment 3
2020-11-10 11:20:19 PST
<
rdar://problem/71246754
>
Aakash Jain
Comment 4
2020-11-17 08:06:45 PST
Reopening to attach new patch.
Aakash Jain
Comment 5
2020-11-17 08:06:48 PST
Created
attachment 414343
[details]
Patch
Aakash Jain
Comment 6
2020-11-17 08:14:56 PST
Follow-up patch to fix this issue with old Buildbot:
https://build.webkit.org/builders/Apple-Mojave-Release-WK1-Tests/builds/19509/steps/extract-test-results/logs/err.text
EWS
Comment 7
2020-11-17 09:07:51 PST
Committed
r269904
: <
https://trac.webkit.org/changeset/269904
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 414343
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug