Bug 218759 - [build.webkit.org] Update ExtractTestResults step for new buildbot
Summary: [build.webkit.org] Update ExtractTestResults step for new buildbot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-11-10 09:21 PST by Aakash Jain
Modified: 2020-11-17 09:07 PST (History)
5 users (show)

See Also:


Attachments
Patch (33.30 KB, patch)
2020-11-10 09:32 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (1.27 KB, patch)
2020-11-17 08:06 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-10 09:21:39 PST
We are planning to upgrade build.webkit.org to latest Buildbot. ExtractTestResults step uses few things which behaves differently in new buildbot (e.g.: self.build.getProperties().render() returns deferred instead of string). We should update the step accordingly.
Comment 1 Aakash Jain 2020-11-10 09:32:38 PST
Created attachment 413708 [details]
Patch
Comment 2 EWS 2020-11-10 11:19:26 PST
Committed r269633: <https://trac.webkit.org/changeset/269633>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413708 [details].
Comment 3 Radar WebKit Bug Importer 2020-11-10 11:20:19 PST
<rdar://problem/71246754>
Comment 4 Aakash Jain 2020-11-17 08:06:45 PST
Reopening to attach new patch.
Comment 5 Aakash Jain 2020-11-17 08:06:48 PST
Created attachment 414343 [details]
Patch
Comment 6 Aakash Jain 2020-11-17 08:14:56 PST
Follow-up patch to fix this issue with old Buildbot: https://build.webkit.org/builders/Apple-Mojave-Release-WK1-Tests/builds/19509/steps/extract-test-results/logs/err.text
Comment 7 EWS 2020-11-17 09:07:51 PST
Committed r269904: <https://trac.webkit.org/changeset/269904>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414343 [details].