Bug 218711 - [build.webkit.org] Do not print master environment variables in build steps
Summary: [build.webkit.org] Do not print master environment variables in build steps
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
Reported: 2020-11-09 08:46 PST by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
5 users (show)

See Also:

Patch (1.51 KB, patch)
2020-11-09 08:49 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-09 08:46:33 PST
We are planning to upgrade build.webkit.org to latest Buildbot. Newer Buildbot (by default) prints all the environment variables of master for any MasterShellCommand command (since https://github.com/buildbot/buildbot/pull/2408). As a side note, we also tried to change the default behavior in https://github.com/buildbot/buildbot/pull/4772, but the PR wasn't accepted.

We should update the MasterShellCommand steps to ensure that we set logEnviron to False.
Comment 1 Aakash Jain 2020-11-09 08:49:08 PST
Created attachment 413589 [details]
Comment 2 EWS 2020-11-09 15:50:11 PST
Committed r269611: <https://trac.webkit.org/changeset/269611>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413589 [details].
Comment 3 Radar WebKit Bug Importer 2020-11-09 15:51:28 PST