Bug 218675 - Remove `localBounds` and `globalBounds` methods from display list items that are not drawing items
Summary: Remove `localBounds` and `globalBounds` methods from display list items that ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on: 218588
Blocks:
  Show dependency tree / graph
 
Reported: 2020-11-06 15:41 PST by Wenson Hsieh
Modified: 2020-11-06 19:54 PST (History)
5 users (show)

See Also:

Attachments
Depends on #218588 (15.47 KB, patch)
2020-11-06 16:24 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
For EWS (15.66 KB, patch)
2020-11-06 17:30 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-11-06 15:41:04 PST 
SSIA
Comment 1 Wenson Hsieh 2020-11-06 16:24:48 PST 
Created attachment 413497 [details]
Depends on #218588
Comment 2 Devin Rousso 2020-11-06 17:23:53 PST 
Comment on attachment 413497 [details]
Depends on #218588

View in context: https://bugs.webkit.org/attachment.cgi?id=413497&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:160
> +        appendWithoutUpdatingExtents<T>(std::forward<Args>(args)...);

I think you could do this with `if constexpr` instead of two overloads
Comment 3 Wenson Hsieh 2020-11-06 17:24:25 PST 
Comment on attachment 413497 [details]
Depends on #218588

I learned from Devin and Andy over Slack that simply wrapping the extent logic in `if constexpr (T::isDrawingItem) { ... }` works here too — I'm going to change it to that instead, since it's a bit cleaner than using std::enable_if.
Comment 4 Wenson Hsieh 2020-11-06 17:30:13 PST 
Created attachment 413503 [details]
For EWS
Comment 5 EWS 2020-11-06 19:54:04 PST 
Committed r269556: <https://trac.webkit.org/changeset/269556>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413503 [details].