Bug 218588 – Add new display list item types in preparation for webkit.org/b/218426

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Wenson Hsieh]

• FlushContext
• SwitchToBuffer
• StrokeLine (though maybe this should be separated out..)

[Wenson Hsieh]

Created attachment 413214 [details]
Patch

[Wenson Hsieh]

Created attachment 413365 [details]
Depends on #218586

[Wenson Hsieh]

Created attachment 413468 [details]
Patch

[Wenson Hsieh]

Comment on attachment 413468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413468&action=review

> Source/WebCore/ChangeLog:40
> +        (WebCore::DisplayList::SwitchToBuffer::SwitchToBuffer):

(As smfr pointed out —) if we want to go this route, SwitchToBuffer should probably be renamed to SwitchToItemBuffer or something to avoid confusing w.r.t. ImageBuffers.

[Wenson Hsieh]

Created attachment 413474 [details]
Rename + add FIXME

[Wenson Hsieh]

Created attachment 413478 [details]
Rename + add FIXME

[Simon Fraser (smfr)]

Comment on attachment 413478 [details]
Rename + add FIXME

View in context: https://bugs.webkit.org/attachment.cgi?id=413478&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:238
> +        get<MetaCommandSwitchTo>().apply(context);

Or not?

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:988
> +    // Handled by client.

Can't we flush via GraphicsContext?

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:999
> +    // Handled by client.

ASSERT_NOT_REACHED()?

[Wenson Hsieh]

Comment on attachment 413478 [details]
Rename + add FIXME

View in context: https://bugs.webkit.org/attachment.cgi?id=413478&action=review

>> Source/WebCore/platform/graphics/displaylists/DisplayListItemBuffer.cpp:238
>> +        get<MetaCommandSwitchTo>().apply(context);
> 
> Or not?

Yep, removed!

>> Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:988
>> +    // Handled by client.
> 
> Can't we flush via GraphicsContext?

My understanding is that context flushes are something handled at the ImageBuffer layer, rather than the GraphicsContext…though GraphicsContext::flush() does seem to be present for the USE(DIRECT2D) build.

>> Source/WebCore/platform/graphics/displaylists/DisplayListItems.cpp:999
>> +    // Handled by client.
> 
> ASSERT_NOT_REACHED()?

(I ended up just deleting `MetaCommandSwitchTo::apply` altogether)

[Wenson Hsieh]

Created attachment 413485 [details]
For EWS

[EWS]

Committed r269551: <https://trac.webkit.org/changeset/269551>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413485 [details].