Bug 218582 - [build.webkit.org] remove unnecessary code from loadConfig
Summary: [build.webkit.org] remove unnecessary code from loadConfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency tree / graph
 
Reported: 2020-11-04 12:31 PST by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2020-11-04 12:39 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-11-04 12:31:55 PST 
loadConfig.py contains code about Python 2.6, e.g.:"Python 2.6 can't handle unicode keys as keyword arguments http://bugs.python.org/issue2646"

This was added ~9 years ago in https://trac.webkit.org/changeset/92772/webkit.

We are using Python 2.7.5 on build.webkit.org and are planning to upgrade to Python 3 soon. We should remove this unnecessary code for Python 2.6 workaround.
Comment 1 Aakash Jain 2020-11-04 12:39:38 PST 
Created attachment 413194 [details]
Patch
Comment 2 dewei_zhu 2020-11-04 12:55:22 PST 
r=me
Comment 3 EWS 2020-11-04 14:56:09 PST 
Committed r269395: <https://trac.webkit.org/changeset/269395>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413194 [details].
Comment 4 Radar WebKit Bug Importer 2020-11-04 14:57:19 PST 
<rdar://problem/71053059>