Bug 218539 - Link against the ANGLE Shared Library
Summary: Link against the ANGLE Shared Library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks: 224532
  Show dependency tree / graph
 
Reported: 2020-11-03 15:36 PST by Dean Jackson
Modified: 2021-04-14 00:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.73 KB, patch)
2020-11-03 15:42 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (9.65 KB, patch)
2021-03-18 14:15 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-11-03 15:36:45 PST 
Link against the ANGLE Shared Library
Comment 1 Dean Jackson 2020-11-03 15:41:33 PST 
<rdar://problem/69062211>
Comment 2 Dean Jackson 2020-11-03 15:42:11 PST 
Created attachment 413115 [details]
Patch
Comment 3 Tim Horton 2020-11-03 16:07:06 PST 
Comment on attachment 413115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413115&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:43
> +WK_EMBEDDED_LIBRARY_DIR = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks

"Embedded" reads like old-school "mobile" to me, but I get that you mean "inside". Alas. I think it's fine.

> Source/WebCore/Configurations/WebCore.xcconfig:72
> +WK_ANGLE_LDFLAGS = -weak-lANGLE-shared;

Is this ... really the right syntax? It looks super weird!
Comment 4 Dean Jackson 2020-11-03 16:09:34 PST 
Comment on attachment 413115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=413115&action=review

>> Source/WebCore/Configurations/WebCore.xcconfig:43
>> +WK_EMBEDDED_LIBRARY_DIR = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks
> 
> "Embedded" reads like old-school "mobile" to me, but I get that you mean "inside". Alas. I think it's fine.

I guess it could be FRAMEWORKS.

>> Source/WebCore/Configurations/WebCore.xcconfig:72
>> +WK_ANGLE_LDFLAGS = -weak-lANGLE-shared;
> 
> Is this ... really the right syntax? It looks super weird!

I believe it is. At least....  it's working :)
Comment 5 Dean Jackson 2020-11-03 16:11:56 PST 
Committed r269344: <https://trac.webkit.org/changeset/269344>
Comment 6 Dean Jackson 2020-11-19 17:07:03 PST 
Reverted in r269364
Comment 7 Dean Jackson 2020-11-19 17:41:42 PST 
Committed r270064: <https://trac.webkit.org/changeset/270064>
Comment 8 Ryan Haddad 2020-11-20 09:57:24 PST 
Reverted r270064 for reason:

Broke the macCatayst build

Committed r270121: <https://trac.webkit.org/changeset/270121>
Comment 9 Alex Christensen 2021-03-18 14:15:48 PDT 
Created attachment 423654 [details]
Patch
Comment 10 Alex Christensen 2021-03-19 15:37:01 PDT 
Now that https://bugs.webkit.org/show_bug.cgi?id=223499 is fixed, this should be good to go.
Comment 11 Alex Christensen 2021-03-19 17:00:05 PDT 
r274750