Bug 223499 - libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
Summary: libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-18 22:13 PDT by Alex Christensen
Modified: 2021-03-19 15:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2021-03-18 22:15 PDT, Alex Christensen 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-03-18 22:13:17 PDT 
libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
Comment 1 Alex Christensen 2021-03-18 22:15:25 PDT 
Created attachment 423692 [details]
Patch
Comment 2 EWS Watchlist 2021-03-18 22:16:33 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alex Christensen 2021-03-19 11:41:15 PDT 
I verified this puts the dylib at /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib in the root.  WebCore roots build to /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework so I think that's the right location.
WK_USE_ALTERNATE_FRAMEWORKS_DIR is only YES in iosmac builds because only WK_ALTERNATE_FRAMEWORKS_DIR_iosmac is defined in the ANGLE project, so this shouldn't break anything else.
Comment 4 Alex Christensen 2021-03-19 15:19:26 PDT 
r274742
Comment 5 Radar WebKit Bug Importer 2021-03-19 15:20:16 PDT 
<rdar://problem/75638888>