RESOLVED FIXED 223499
libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots 
https://bugs.webkit.org/show_bug.cgi?id=223499
Summary libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
Alex Christensen
Reported 2021-03-18 22:13:17 PDT
libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots
Attachments
Patch (2.11 KB, patch)
2021-03-18 22:15 PDT, Alex Christensen 		dino: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-03-18 22:15:25 PDT
Created attachment 423692 [details] Patch
EWS Watchlist
Comment 2 2021-03-18 22:16:33 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Alex Christensen
Comment 3 2021-03-19 11:41:15 PDT
I verified this puts the dylib at /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks/libANGLE-shared.dylib in the root. WebCore roots build to /System/iOSSupport/System/Library/PrivateFrameworks/WebCore.framework so I think that's the right location. WK_USE_ALTERNATE_FRAMEWORKS_DIR is only YES in iosmac builds because only WK_ALTERNATE_FRAMEWORKS_DIR_iosmac is defined in the ANGLE project, so this shouldn't break anything else.
Alex Christensen
Comment 4 2021-03-19 15:19:26 PDT
r274742
Radar WebKit Bug Importer
Comment 5 2021-03-19 15:20:16 PDT
<rdar://problem/75638888>
Note You need to log in before you can comment on or make changes to this bug.