Bug 218302 - Rename build.webkit.org-config directory to build-webkit-org
Summary: Rename build.webkit.org-config directory to build-webkit-org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
 
Reported: 2020-10-28 11:46 PDT by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
9 users (show)

See Also:


Attachments
Patch (1.75 MB, patch)
2020-10-28 11:50 PDT, Aakash Jain
jbedard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-28 11:46:50 PDT
We should rename "build.webkit.org-config" directory inside Tools/CISupport to "build-webkit-org" to make the name more readable.

Note that "build.webkit.org" directory name isn't a good option, since in the long-term we want to run build.webkit.org unit-tests using test-webkitpy script and that requires directory name to not have dots.
Comment 1 Aakash Jain 2020-10-28 11:50:04 PDT
Created attachment 412555 [details]
Patch
Comment 2 Jonathan Bedard 2020-10-28 11:52:36 PDT
Comment on attachment 412555 [details]
Patch

Are we doing anything with symlinks here? Do we need to?
Comment 3 Stephan Szabo 2020-10-28 11:58:43 PDT
Are the files that didn't seem to move in the patch (like the README) unnecessary now?
Comment 4 Aakash Jain 2020-10-28 12:04:03 PDT
(In reply to Stephan Szabo from comment #3)
> Are the files that didn't seem to move in the patch (like the README) unnecessary now?
I did "svn mv build.webkit.org-config build-webkit-org". So there shouldn't be any such files. README is also moved in this patch. Maybe the patch review UI doesn't show it properly.
Comment 5 Aakash Jain 2020-10-28 12:08:29 PDT
(In reply to Jonathan Bedard from comment #2)
> Are we doing anything with symlinks here? Do we need to?
Doesn't look like we need to create symlink for this. There aren't much external directories referencing this. 

build-webkit-org/steps.py reference it in RunDashboardTests and ews-build/steps.py reference it in RunBuildWebKitOrgUnitTests. For those we can just restart Buildbot to pick up new location.
Comment 6 Aakash Jain 2020-10-28 13:56:39 PDT
Committed r269120: <https://trac.webkit.org/changeset/269120>
Comment 7 Radar WebKit Bug Importer 2020-10-28 13:57:21 PDT
<rdar://problem/70778907>
Comment 8 Carlos Alberto Lopez Perez 2020-10-28 14:04:58 PDT
(In reply to Aakash Jain from comment #0)
> Note that "build.webkit.org" directory name isn't a good option, since in
> the long-term we want to run build.webkit.org unit-tests using test-webkitpy
> script and that requires directory name to not have dots.

It would be great to run the buildbot unit-tests with test-webkitpy :)
Comment 9 Aakash Jain 2020-10-29 16:04:25 PDT
Restarted build.webkit.org to pick up this change. Seems to be working fine.