RESOLVED FIXED 218302
Rename build.webkit.org-config directory to build-webkit-org 
https://bugs.webkit.org/show_bug.cgi?id=218302
Summary Rename build.webkit.org-config directory to build-webkit-org
Aakash Jain
Reported 2020-10-28 11:46:50 PDT
We should rename "build.webkit.org-config" directory inside Tools/CISupport to "build-webkit-org" to make the name more readable. Note that "build.webkit.org" directory name isn't a good option, since in the long-term we want to run build.webkit.org unit-tests using test-webkitpy script and that requires directory name to not have dots.
Attachments
Patch (1.75 MB, patch)
2020-10-28 11:50 PDT, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-10-28 11:50:04 PDT
Created attachment 412555 [details] Patch
Jonathan Bedard
Comment 2 2020-10-28 11:52:36 PDT
Comment on attachment 412555 [details] Patch Are we doing anything with symlinks here? Do we need to?
Stephan Szabo
Comment 3 2020-10-28 11:58:43 PDT
Are the files that didn't seem to move in the patch (like the README) unnecessary now?
Aakash Jain
Comment 4 2020-10-28 12:04:03 PDT
(In reply to Stephan Szabo from comment #3) > Are the files that didn't seem to move in the patch (like the README) unnecessary now? I did "svn mv build.webkit.org-config build-webkit-org". So there shouldn't be any such files. README is also moved in this patch. Maybe the patch review UI doesn't show it properly.
Aakash Jain
Comment 5 2020-10-28 12:08:29 PDT
(In reply to Jonathan Bedard from comment #2) > Are we doing anything with symlinks here? Do we need to? Doesn't look like we need to create symlink for this. There aren't much external directories referencing this. build-webkit-org/steps.py reference it in RunDashboardTests and ews-build/steps.py reference it in RunBuildWebKitOrgUnitTests. For those we can just restart Buildbot to pick up new location.
Aakash Jain
Comment 6 2020-10-28 13:56:39 PDT
Committed r269120: <https://trac.webkit.org/changeset/269120>
Radar WebKit Bug Importer
Comment 7 2020-10-28 13:57:21 PDT
<rdar://problem/70778907>
Carlos Alberto Lopez Perez
Comment 8 2020-10-28 14:04:58 PDT
(In reply to Aakash Jain from comment #0) > Note that "build.webkit.org" directory name isn't a good option, since in > the long-term we want to run build.webkit.org unit-tests using test-webkitpy > script and that requires directory name to not have dots. It would be great to run the buildbot unit-tests with test-webkitpy :)
Aakash Jain
Comment 9 2020-10-29 16:04:25 PDT
Restarted build.webkit.org to pick up this change. Seems to be working fine.
Note You need to log in before you can comment on or make changes to this bug.