Bug 218272 - Extend check-for-inappropriate-files-in-framework to WebKitLegacy and JavaScriptCore
Summary: Extend check-for-inappropriate-files-in-framework to WebKitLegacy and JavaScr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-27 19:04 PDT by Keith Rollin
Modified: 2020-11-03 09:52 PST (History)
10 users (show)

See Also:

Attachments
Patch (9.07 KB, patch)
2020-11-03 00:01 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-10-27 19:04:17 PDT 
Bug 218268 reports that some *.txt files got included in WebKitLegacy. To help protect against this happening in the future, extend check-for-inappropriate-files-in-framework to check for *.txt files, and apply the script to WebKitLegacy and JavaScriptCore in addition to WebCore and WebKit.
Comment 1 Radar WebKit Bug Importer 2020-10-27 19:04:29 PDT 
<rdar://problem/70748116>
Comment 2 Keith Rollin 2020-10-27 19:55:11 PDT 
The patch is done, but I can't upload it until the bots are cleaned of the *.txt files that this patch is supposed to detect.
Comment 3 Keith Rollin 2020-11-02 23:59:33 PST 
Added a suggestion from David to manually remove those files so that check-for-inappropriate-files-in-framework won't complain about them.
Comment 4 Keith Rollin 2020-11-03 00:01:02 PST 
Created attachment 413010 [details]
Patch
Comment 5 EWS 2020-11-03 09:52:34 PST 
Committed r269310: <https://trac.webkit.org/changeset/269310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 413010 [details].