Bug 218268 - Unexpected txt file: .../WebKitLegacy.framework/.../Sources.txt
Summary: Unexpected txt file: .../WebKitLegacy.framework/.../Sources.txt
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2020-10-27 17:55 PDT by Keith Rollin
Modified: 2020-10-27 19:26 PDT (History)
7 users (show)

See Also:

Patch (3.33 KB, patch)
2020-10-27 18:07 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-10-27 17:55:15 PDT
Sources.txt and SourcesCocoa.txt were added to the WebKitLegacy project in https://trac.webkit.org/changeset/247401 as targets of the WebKitLegacy target. This caused them to be treated as resources and so were copied to the framework's Resources directory on a build. These files don't need to be included in the build, and so need to be removed from that target.
Comment 1 Keith Rollin 2020-10-27 17:56:14 PDT
Comment 2 Keith Rollin 2020-10-27 18:07:52 PDT
Created attachment 412489 [details]
Comment 3 Tim Horton 2020-10-27 18:12:46 PDT
Does this leave them in the project? I think they should be in the project, just not a part of any target
Comment 4 Keith Rollin 2020-10-27 18:13:36 PDT
Yes, they're still in the project, so you can select and open them. They were merely removed from the target.
Comment 5 Keith Miller 2020-10-27 18:19:22 PDT
Seems reasonable to me.
Comment 6 Simon Fraser (smfr) 2020-10-27 18:20:47 PDT
Don't we have a script that checks for files added to frameworks by mistake? Why didn't it catch this?
Comment 7 Simon Fraser (smfr) 2020-10-27 18:22:48 PDT
"Check For Inappropriate Files In Framework"
Comment 8 Keith Rollin 2020-10-27 18:28:41 PDT
check-for-inappropriate-files-in-framework needs to be attached to WebKitLegacy (and JavaScriptCore) and updated to scan for *.txt files.
Comment 9 EWS 2020-10-27 19:26:01 PDT
Committed r269093: <https://trac.webkit.org/changeset/269093>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412489 [details].