Bug 218234 - [build.webkit.org] loadConfig unittest fail depending on locally installed version of buildbot
Summary: [build.webkit.org] loadConfig unittest fail depending on locally installed ve...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks: 175056
  Show dependency treegraph
 
Reported: 2020-10-27 08:07 PDT by Aakash Jain
Modified: 2021-02-08 07:37 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2020-10-27 08:16 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
Patch (1.29 KB, patch)
2020-10-28 16:37 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-10-27 08:07:10 PDT
[build.webkit.org] loadConfig unittest fail depending on locally installed version of buildbot. This is happening since r268749 which added "import loadConfig" statement in loadConfig unittest.

We should make it use the autoinstalled version of buildbot.


With latest buildbot installed locally, loadConfig unittest fail with following error:

Traceback (most recent call last):
  File "loadConfig_unittest.py", line 30, in <module>
    import loadConfig
  File "/Volumes/Data/aakash_jain/code3/OpenSource/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py", line 35, in <module>
    from factories import *
  File "/Volumes/Data/aakash_jain/code3/OpenSource/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py", line 26, in <module>
    from steps import *
  File "/Volumes/Data/aakash_jain/code3/OpenSource/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py", line 107, in <module>
    class CheckOutSource(source.SVN):
AttributeError: 'module' object has no attribute 'SVN'
Comment 1 Aakash Jain 2020-10-27 08:16:39 PDT
Created attachment 412422 [details]
Patch
Comment 2 Aakash Jain 2020-10-28 16:37:01 PDT
Created attachment 412588 [details]
Patch
Comment 3 EWS 2020-10-28 17:10:31 PDT
Committed r269132: <https://trac.webkit.org/changeset/269132>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412588 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-28 17:16:10 PDT
<rdar://problem/70787390>