Bug 218057 - Turn ScriptExecutionContext::vm() into a pure virtual function
Summary: Turn ScriptExecutionContext::vm() into a pure virtual function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-21 16:08 PDT by Chris Dumez
Modified: 2020-10-22 09:24 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.15 KB, patch)
2020-10-21 16:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-21 16:08:59 PDT
Turn ScriptExecutionContext::vm() into a pure virtual function instead of using a non-virtual function that does type-checking inside.
Comment 1 Chris Dumez 2020-10-21 16:10:04 PDT
Created attachment 412043 [details]
Patch
Comment 2 Geoffrey Garen 2020-10-21 16:17:14 PDT
Comment on attachment 412043 [details]
Patch

r=me
Comment 3 EWS 2020-10-22 09:23:13 PDT
Committed r268868: <https://trac.webkit.org/changeset/268868>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412043 [details].
Comment 4 Radar WebKit Bug Importer 2020-10-22 09:24:18 PDT
<rdar://problem/70576507>