Bug 218028 - Simplify ScriptExecutionContext::vm()
Summary: Simplify ScriptExecutionContext::vm()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 217724
  Show dependency tree / graph
 
Reported: 2020-10-21 08:50 PDT by Chris Dumez
Modified: 2020-10-21 16:10 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2020-10-21 08:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-21 08:50:59 PDT 
Simplify ScriptExecutionContext::vm().
Comment 1 Chris Dumez 2020-10-21 08:51:39 PDT 
Created attachment 411992 [details]
Patch
Comment 2 EWS 2020-10-21 09:40:50 PDT 
Committed r268801: <https://trac.webkit.org/changeset/268801>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411992 [details].
Comment 3 Radar WebKit Bug Importer 2020-10-21 09:41:20 PDT 
<rdar://problem/70532783>
Comment 4 Sam Weinig 2020-10-21 15:24:43 PDT 
Comment on attachment 411992 [details]
Patch

I feel like this would be even better as a pure-virtual function that the subclasses would implement. That would avoid one virtual function call in the worker/worklet case as well.
Comment 5 Chris Dumez 2020-10-21 15:27:29 PDT 
(In reply to Sam Weinig from comment #4)
> Comment on attachment 411992 [details]
> Patch
> 
> I feel like this would be even better as a pure-virtual function that the
> subclasses would implement. That would avoid one virtual function call in
> the worker/worklet case as well.

Good idea. I will look into this shortly.
Comment 6 Sam Weinig 2020-10-21 15:33:38 PDT 
(In reply to Chris Dumez from comment #5)
> (In reply to Sam Weinig from comment #4)
> > Comment on attachment 411992 [details]
> > Patch
> > 
> > I feel like this would be even better as a pure-virtual function that the
> > subclasses would implement. That would avoid one virtual function call in
> > the worker/worklet case as well.
> 
> Good idea. I will look into this shortly.

👍
Comment 7 Chris Dumez 2020-10-21 16:10:32 PDT 
(In reply to Sam Weinig from comment #6)
> (In reply to Chris Dumez from comment #5)
> > (In reply to Sam Weinig from comment #4)
> > > Comment on attachment 411992 [details]
> > > Patch
> > > 
> > > I feel like this would be even better as a pure-virtual function that the
> > > subclasses would implement. That would avoid one virtual function call in
> > > the worker/worklet case as well.
> > 
> > Good idea. I will look into this shortly.
> 
> 👍

https://bugs.webkit.org/show_bug.cgi?id=218057