RESOLVED DUPLICATE of bug 218001 218000
Remove use of in-makefile grepping of FEATURE_AND_PLATFORM_DEFINES 
https://bugs.webkit.org/show_bug.cgi?id=218000
Summary Remove use of in-makefile grepping of FEATURE_AND_PLATFORM_DEFINES
Sam Weinig
Reported 2020-10-20 16:08:19 PDT
To make things simpler, and allow for passing FEATURE_AND_PLATFORM_DEFINES as a file rather than on the command line, we should remove the in-makefile use of grepping FEATURE_AND_PLATFORM_DEFINES. For the ones conditionalizing adding to ADDITIONAL_BINDING_IDLS, those IDLs should just have the appropriate Conditional=* extended attribute added, then they can be included unconditionally in the makefile. For the ones conditionalizing adding go USER_AGENT_STYLE_SHEETS, again, there doesn’t seem a real reason to keep that. The sheets are all preprocessed anyway, so we can just move those #ifdefs into the files.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-10-20 16:42:40 PDT
*** This bug has been marked as a duplicate of bug 218001 ***
Note You need to log in before you can comment on or make changes to this bug.