Bug 217951 - WebDriver: sequence of char key press is not supported
Summary: WebDriver: sequence of char key press is not supported
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 217950
Blocks: gtk-webdriver
  Show dependency tree / graph
 
Reported: 2020-10-20 06:13 PDT by Carlos Garcia Campos
Modified: 2020-10-27 06:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.42 KB, patch)
2020-10-20 06:18 PDT, Carlos Garcia Campos 		bburg: review-
Details | Formatted Diff | Diff
Patch (8.53 KB, patch)
2020-10-22 03:01 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-10-20 06:13:56 PDT 
We are assuming there can be only one char key pressed at a time. There's on test failing because of this:

imported/w3c/webdriver/tests/perform_actions/key_events.py::test_sequence_of_keydown_printable_keys_sends_events
Comment 1 Carlos Garcia Campos 2020-10-20 06:18:20 PDT 
Created attachment 411859 [details]
Patch
Comment 2 BJ Burg 2020-10-20 08:34:50 PDT 
Comment on attachment 411859 [details]
Patch

r- due to failing build.

Overall this looks like an improvement. I am worried about iteration order of the char keys being undefined and causing flaky test failures. Can we use ListHashSet to avoid this?
Comment 3 Carlos Garcia Campos 2020-10-21 00:34:27 PDT 
(In reply to Brian Burg from comment #2)
> Comment on attachment 411859 [details]
> Patch
> 
> r- due to failing build.

EWS is red because the patch depends on bug #217950.

> Overall this looks like an improvement. I am worried about iteration order
> of the char keys being undefined and causing flaky test failures. Can we use
> ListHashSet to avoid this?

I'll submit a rebased patch after landing bug #217950 using LinkHashSet
Comment 4 Carlos Garcia Campos 2020-10-22 03:01:29 PDT 
Created attachment 412080 [details]
Patch
Comment 5 BJ Burg 2020-10-26 17:00:25 PDT 
Comment on attachment 412080 [details]
Patch

r=me
Comment 6 Radar WebKit Bug Importer 2020-10-27 06:14:47 PDT 
<rdar://problem/70719725>
Comment 7 Carlos Garcia Campos 2020-10-27 06:26:59 PDT 
Committed r269035: <https://trac.webkit.org/changeset/269035>