Bug 217950 - WebDriver: handle key events with non-ASCII unicode code point
Summary: WebDriver: handle key events with non-ASCII unicode code point
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: gtk-webdriver 217951
  Show dependency tree / graph
 
Reported: 2020-10-20 06:05 PDT by Carlos Garcia Campos
Modified: 2020-10-22 02:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2020-10-20 06:09 PDT, Carlos Garcia Campos 		clopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-10-20 06:05:58 PDT 
We are assuming that key events are limited to ASCII, but they contain a unicode code point. This makes several tests to fail:



imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\xe0-]
imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u0416-]
imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\u2603-]
imported/w3c/webdriver/tests/perform_actions/key_events.py::test_printable_key_sends_correct_events[\uf6c2-]
Comment 1 Carlos Garcia Campos 2020-10-20 06:09:20 PDT 
Created attachment 411858 [details]
Patch

I've remove the test expectations, but those tests are still failing due to https://github.com/web-platform-tests/wpt/pull/26183
Comment 2 Radar WebKit Bug Importer 2020-10-20 08:57:52 PDT 
<rdar://problem/70487022>
Comment 3 Carlos Garcia Campos 2020-10-22 02:42:29 PDT 
Committed r268858: <https://trac.webkit.org/changeset/268858>