Bug 217914 – [ews] use -o while unzipping layout-test-results.zip

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We should use -o flag while unzipping layout-test-results.zip in EWS to improve unzip performance.

[Aakash Jain]

Created attachment 411767 [details]
Patch

[Jonathan Bedard]

Comment on attachment 411767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411767&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:2740
>  

unzip says that -o overwrites files without prompting....how did we get away with this in the first place?

[Aakash Jain]

In case of EWS, the file shouldn't exist previously. The uploaded file name is unique for each build.

[Ling Ho]

This is to eliminate the unecessary four lstat and stat calls everytime a file is getting extracted. But I haven't verified if -o indeed does that. Aakash have you?

[EWS]

Committed r268689: <https://trac.webkit.org/changeset/268689>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411767 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70456769>

[Ling Ho]

Looks like adding -o won't help. Unzip is still calling lstat and stat (twice each) before creating a file. So don't expect any performance improvement.

[Aakash Jain]

Discussed with Ling offline. As per him: I guess there is no harm leaving -o there. Might be the right thing to do because if for whatever reason the files were there before, we should overwrite.