Bug 217488 - [LFC][Integration] Enable overflow hidden
Summary: [LFC][Integration] Enable overflow hidden
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 217526 217527 217608
Blocks:
  Show dependency tree / graph
 
Reported: 2020-10-08 12:12 PDT by zalan
Modified: 2020-10-13 11:17 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.85 KB, patch)
2020-10-08 12:16 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.32 KB, patch)
2020-10-09 03:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.22 KB, patch)
2020-10-09 15:01 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-10-08 12:12:57 PDT 
ssia
Comment 1 zalan 2020-10-08 12:16:28 PDT 
Created attachment 410870 [details]
Patch
Comment 2 zalan 2020-10-09 03:02:29 PDT 
Created attachment 410926 [details]
Patch
Comment 3 Antti Koivisto 2020-10-09 12:29:18 PDT 
Comment on attachment 410926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410926&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:198
> +        SET_REASON_AND_RETURN_IF_NEEDED(FlowHasOverflowNotVisible, reasons, includeReasons);

Can you also remove FlowHasOverflowNotVisible enum value?
Comment 4 Antti Koivisto 2020-10-09 12:29:40 PDT 
> Can you also remove FlowHasOverflowNotVisible enum value?

Oh I guess not since it just moves.
Comment 5 zalan 2020-10-09 12:30:38 PDT 
(In reply to Antti Koivisto from comment #4)
> > Can you also remove FlowHasOverflowNotVisible enum value?
> 
> Oh I guess not since it just moves.
Yea we still have the auto/scroll case here.
Comment 6 zalan 2020-10-09 15:01:16 PDT 
Created attachment 410978 [details]
Patch
Comment 7 EWS 2020-10-09 16:02:05 PDT 
Committed r268294: <https://trac.webkit.org/changeset/268294>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410978 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-09 16:03:17 PDT 
<rdar://problem/70157279>
Comment 9 Aakash Jain 2020-10-12 08:13:51 PDT 
This (In reply to EWS from comment #7)
> Committed r268294: <https://trac.webkit.org/changeset/268294>
This seems to have broken a test on ios-wk2: imported/blink/fast/css/zoomed-intrinsic-width.html 

EWS also indicated this failure in https://ews-build.webkit.org/#/builders/24/builds/27791. Should have waited for ews to complete before cq+ing the patch.
Comment 10 WebKit Commit Bot 2020-10-12 08:14:52 PDT 
Re-opened since this is blocked by bug 217608