RESOLVED FIXED 217488
[LFC][Integration] Enable overflow hidden 
https://bugs.webkit.org/show_bug.cgi?id=217488
Summary [LFC][Integration] Enable overflow hidden
zalan
Reported 2020-10-08 12:12:57 PDT
ssia
Attachments
Patch (2.85 KB, patch)
2020-10-08 12:16 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.32 KB, patch)
2020-10-09 03:02 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.22 KB, patch)
2020-10-09 15:01 PDT, zalan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-10-08 12:16:28 PDT
Created attachment 410870 [details] Patch
zalan
Comment 2 2020-10-09 03:02:29 PDT
Created attachment 410926 [details] Patch
Antti Koivisto
Comment 3 2020-10-09 12:29:18 PDT
Comment on attachment 410926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410926&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:198 > + SET_REASON_AND_RETURN_IF_NEEDED(FlowHasOverflowNotVisible, reasons, includeReasons); Can you also remove FlowHasOverflowNotVisible enum value?
Antti Koivisto
Comment 4 2020-10-09 12:29:40 PDT
> Can you also remove FlowHasOverflowNotVisible enum value? Oh I guess not since it just moves.
zalan
Comment 5 2020-10-09 12:30:38 PDT
(In reply to Antti Koivisto from comment #4) > > Can you also remove FlowHasOverflowNotVisible enum value? > > Oh I guess not since it just moves. Yea we still have the auto/scroll case here.
zalan
Comment 6 2020-10-09 15:01:16 PDT
Created attachment 410978 [details] Patch
EWS
Comment 7 2020-10-09 16:02:05 PDT
Committed r268294: <https://trac.webkit.org/changeset/268294> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410978 [details].
Radar WebKit Bug Importer
Comment 8 2020-10-09 16:03:17 PDT
<rdar://problem/70157279>
Aakash Jain
Comment 9 2020-10-12 08:13:51 PDT
This (In reply to EWS from comment #7) > Committed r268294: <https://trac.webkit.org/changeset/268294> This seems to have broken a test on ios-wk2: imported/blink/fast/css/zoomed-intrinsic-width.html EWS also indicated this failure in https://ews-build.webkit.org/#/builders/24/builds/27791. Should have waited for ews to complete before cq+ing the patch.
WebKit Commit Bot
Comment 10 2020-10-12 08:14:52 PDT
Re-opened since this is blocked by bug 217608
Note You need to log in before you can comment on or make changes to this bug.