Bug 217475 - [Mac] imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html is failing
Summary: [Mac] imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html is f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on:
Blocks: 167729
  Show dependency tree / graph
 
Reported: 2020-10-08 07:26 PDT by Oriol Brufau
Modified: 2020-10-10 05:51 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.60 KB, patch)
2020-10-08 07:36 PDT, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Patch (3.48 KB, patch)
2020-10-08 09:42 PDT, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Patch (2.54 KB, patch)
2020-10-09 18:53 PDT, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2020-10-09 19:05 PDT, Oriol Brufau 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2020-10-08 07:26:36 PDT 
imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html was already flaky (bug 217161).
But bug 167729 made it worse.

Before r267940, the expectation for the test in all platforms was (1):

FAIL Selection ending in ::before assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::before
FAIL Selection ending in ::marker assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::marker
FAIL Selection ending in ::before-marker assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::before-marker

But in r267940 I added a different expectation for Mac (2):

FAIL Selection ending in ::before assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::before
FAIL Selection ending in ::marker assert_equals: toString expected "hello" but got ""
PASS Selection contained in ::marker
FAIL Selection ending in ::before-marker assert_equals: toString expected "hello" but got ""
FAIL Selection contained in ::before-marker assert_equals: toString expected "" but got "h"

But this made it fail in Mac Catalina, which was producing (1).

So r268171 changed the Mac expectation to match (1).
But this made the test fail in Mac Mojave, which was expecting (2).

Then, it seems:
 - LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should keep having (1).
 - LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should be removed.
 - LayoutTests/platform/mac-mojave/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should be created with (2).
Comment 1 Oriol Brufau 2020-10-08 07:36:24 PDT 
Created attachment 410839 [details]
Patch
Comment 3 Oriol Brufau 2020-10-08 09:42:23 PDT 
Created attachment 410850 [details]
Patch
Comment 4 EWS 2020-10-09 18:36:28 PDT 
Tools/Scripts/svn-apply failed to apply attachment 410850 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 5 Oriol Brufau 2020-10-09 18:53:57 PDT 
Created attachment 410993 [details]
Patch
Comment 6 Oriol Brufau 2020-10-09 19:05:36 PDT 
Created attachment 410995 [details]
Patch
Comment 7 EWS 2020-10-10 05:50:56 PDT 
Committed r268310: <https://trac.webkit.org/changeset/268310>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410995 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-10 05:51:20 PDT 
<rdar://problem/70170520>