RESOLVED FIXED 217475
[Mac] imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html is failing 
https://bugs.webkit.org/show_bug.cgi?id=217475
Summary [Mac] imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html is f...
Oriol Brufau
Reported 2020-10-08 07:26:36 PDT
imported/w3c/web-platform-tests/css/css-pseudo/text-selection.html was already flaky (bug 217161). But bug 167729 made it worse. Before r267940, the expectation for the test in all platforms was (1): FAIL Selection ending in ::before assert_equals: toString expected "hello" but got "" PASS Selection contained in ::before FAIL Selection ending in ::marker assert_equals: toString expected "hello" but got "" PASS Selection contained in ::marker FAIL Selection ending in ::before-marker assert_equals: toString expected "hello" but got "" PASS Selection contained in ::before-marker But in r267940 I added a different expectation for Mac (2): FAIL Selection ending in ::before assert_equals: toString expected "hello" but got "" PASS Selection contained in ::before FAIL Selection ending in ::marker assert_equals: toString expected "hello" but got "" PASS Selection contained in ::marker FAIL Selection ending in ::before-marker assert_equals: toString expected "hello" but got "" FAIL Selection contained in ::before-marker assert_equals: toString expected "" but got "h" But this made it fail in Mac Catalina, which was producing (1). So r268171 changed the Mac expectation to match (1). But this made the test fail in Mac Mojave, which was expecting (2). Then, it seems: - LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should keep having (1). - LayoutTests/platform/mac/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should be removed. - LayoutTests/platform/mac-mojave/imported/w3c/web-platform-tests/css/css-pseudo/text-selection-expected.txt should be created with (2).
Attachments
Patch (2.60 KB, patch)
2020-10-08 07:36 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Patch (3.48 KB, patch)
2020-10-08 09:42 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Patch (2.54 KB, patch)
2020-10-09 18:53 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Patch (2.79 KB, patch)
2020-10-09 19:05 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2020-10-08 07:36:24 PDT
Created attachment 410839 [details] Patch
Oriol Brufau
Comment 3 2020-10-08 09:42:23 PDT
Created attachment 410850 [details] Patch
EWS
Comment 4 2020-10-09 18:36:28 PDT
Tools/Scripts/svn-apply failed to apply attachment 410850 [details] to trunk. Please resolve the conflicts and upload a new patch.
Oriol Brufau
Comment 5 2020-10-09 18:53:57 PDT
Created attachment 410993 [details] Patch
Oriol Brufau
Comment 6 2020-10-09 19:05:36 PDT
Created attachment 410995 [details] Patch
EWS
Comment 7 2020-10-10 05:50:56 PDT
Committed r268310: <https://trac.webkit.org/changeset/268310> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410995 [details].
Radar WebKit Bug Importer
Comment 8 2020-10-10 05:51:20 PDT
<rdar://problem/70170520>
Note You need to log in before you can comment on or make changes to this bug.