Remove OpenGL (CGL) and OpenGL ES (EAGL) backends. Make ANGLE the only backend. Current layering violations and technical dept makes it too laboursome to implement the blocking bugs.
Created attachment 410745 [details] Patch
Comment on attachment 410745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410745&action=review Looks great. > Source/WebCore/platform/graphics/GraphicsContextGL.h:780 > + Should not leave this extra blank line. > Source/WebCore/platform/graphics/cocoa/WebGLLayer.h:38 > + Should not add this extra blank line here. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:52 > +namespace { We mostly still use static rather than anonymous namespace for this kind of thing in WebKit. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:53 > +// TODO: Fix style to allow multi-line raw strings. Not an important follow-up so I would omit this comment. Also. WebKit usies FIXME, not TODO. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:54 > +#define SHADER(text) #text##_s Why do we need this macro at all? It does not seem to add any helpful abstraction. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:56 > +const ASCIILiteral s_rgbVertexShader { SHADER( constexpr auto or static constexpr auto?
Comment on attachment 410745 [details] Patch Awesome!
Created attachment 410819 [details] Patch
Committed r268198: <https://trac.webkit.org/changeset/268198> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410819 [details].
<rdar://problem/70103808>
Has this day really finally come? Exciting!