Bug 217213 - Refactor WebGL implementation to use only GraphicsContextGL
Summary: Refactor WebGL implementation to use only GraphicsContextGL
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Macintosh Unspecified
: P1 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 217377 217426 217212 217374
Blocks: webglgpup 217216
  Show dependency treegraph
 
Reported: 2020-10-02 04:20 PDT by Kimmo Kinnunen
Modified: 2020-10-16 08:09 PDT (History)
13 users (show)

See Also:


Attachments
Patch (113.17 KB, patch)
2020-10-14 05:59 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (107.89 KB, patch)
2020-10-14 06:03 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (113.07 KB, patch)
2020-10-14 11:45 PDT, Kimmo Kinnunen
dino: review+
Details | Formatted Diff | Diff
Patch (196.16 KB, patch)
2020-10-15 05:48 PDT, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (112.55 KB, patch)
2020-10-15 23:50 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (306.14 KB, patch)
2020-10-16 04:18 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (196.16 KB, patch)
2020-10-16 04:25 PDT, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (196.16 KB, patch)
2020-10-16 04:28 PDT, Kimmo Kinnunen
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (196.18 KB, patch)
2020-10-16 04:37 PDT, Kimmo Kinnunen
kkinnunen: review?
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2020-10-02 04:20:00 PDT
Refactor WebGL implementation to use only GraphicsContextGL

Current implementation uses GraphicsContextGLOpenGL. This cannot support remote WebGL
Comment 1 Radar WebKit Bug Importer 2020-10-02 04:20:42 PDT
<rdar://problem/69876105>
Comment 2 Kimmo Kinnunen 2020-10-14 05:59:45 PDT
Created attachment 411315 [details]
Patch
Comment 3 Kimmo Kinnunen 2020-10-14 06:03:36 PDT
Created attachment 411317 [details]
Patch
Comment 4 Kimmo Kinnunen 2020-10-14 11:45:31 PDT
Created attachment 411353 [details]
Patch
Comment 5 Kimmo Kinnunen 2020-10-15 05:48:17 PDT
Created attachment 411433 [details]
Patch
Comment 6 Dean Jackson 2020-10-15 15:50:21 PDT
Comment on attachment 411353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411353&action=review

> Source/WebCore/ChangeLog:24
> +        Introduce a virtual member fuction in GraphicsContextGL for

typo function
Comment 7 Kimmo Kinnunen 2020-10-15 23:50:16 PDT
Created attachment 411539 [details]
Patch
Comment 8 EWS 2020-10-16 01:18:32 PDT
kkinnunen@apple.com does not have reviewer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 411539 [details] from commit queue.
Comment 9 EWS 2020-10-16 03:56:05 PDT
Committed r268578: <https://trac.webkit.org/changeset/268578>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411539 [details].
Comment 10 Kimmo Kinnunen 2020-10-16 03:57:13 PDT
patches still left
Comment 11 Kimmo Kinnunen 2020-10-16 04:18:30 PDT
Created attachment 411554 [details]
Patch
Comment 12 Kimmo Kinnunen 2020-10-16 04:25:01 PDT
Created attachment 411555 [details]
Patch
Comment 13 Kimmo Kinnunen 2020-10-16 04:28:59 PDT
Created attachment 411556 [details]
Patch
Comment 14 Kimmo Kinnunen 2020-10-16 04:37:17 PDT
Created attachment 411557 [details]
Patch