WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21735
Emit profiling instrumentation only if the Web Inspector's profiling feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=21735
Summary
Emit profiling instrumentation only if the Web Inspector's profiling feature ...
Geoffrey Garen
Reported
2008-10-18 16:18:58 PDT
Patch coming.
Attachments
patch
(45.54 KB, patch)
2008-10-18 16:50 PDT
,
Geoffrey Garen
no flags
Details
Formatted Diff
Diff
patch - removed the comment tim mentioned
(45.53 KB, patch)
2008-10-18 17:55 PDT
,
Geoffrey Garen
darin
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Geoffrey Garen
Comment 1
2008-10-18 16:50:28 PDT
Created
attachment 24493
[details]
patch
Timothy Hatcher
Comment 2
2008-10-18 17:30:22 PDT
Comment on
attachment 24493
[details]
patch // Profiler check emitGetCTIParam(CTI_ARGS_profilerReference, X86::eax); You should remove that comment too. Maybe recompileAllJSFunctionsSoon() should be on some other class or standalone function? Or moved to JSCore? It seems weird for it to be on the JavaScriptDebugServer now that it is used be the profiler.
Geoffrey Garen
Comment 3
2008-10-18 17:54:55 PDT
(In reply to
comment #2
)
> (From update of
attachment 24493
[details]
[edit]) > // Profiler check > emitGetCTIParam(CTI_ARGS_profilerReference, X86::eax); > > You should remove that comment too.
Fixed!
> Maybe recompileAllJSFunctionsSoon() should be on some other class or standalone > function? Or moved to JSCore? It seems weird for it to be on the > JavaScriptDebugServer now that it is used be the profiler.
recompileAllJSFunctionsSoon() can't move to JSCore unless we move the Timer class down to WTF, too. It can't be standalone unless we rework the Timer class to support standalone functions in addition to member functions. Maybe these changes would be worth it, though. Ideally, I think we'd use a shared object like GCController. JavaScriptDebugServer seemed like that object to me. It's not the profiler, but it makes sense to me that it knows how to recompile things, and that the profiler / Settings object can use it for that purpose. But maybe I should just split off a new object -- CompilerController?
Geoffrey Garen
Comment 4
2008-10-18 17:55:58 PDT
Created
attachment 24496
[details]
patch - removed the comment tim mentioned Updated patch to remove the comment Tim mentioned.
Darin Adler
Comment 5
2008-10-18 23:06:58 PDT
Comment on
attachment 24496
[details]
patch - removed the comment tim mentioned r=me
Timothy Hatcher
Comment 6
2008-10-23 13:34:30 PDT
Geoff landed this in
r37730
.
http://trac.webkit.org/changeset/37730
Cameron Zwarich (cpst)
Comment 7
2008-11-24 17:09:40 PST
***
Bug 21296
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug