Bug 21296 - Remove profiling hooks when not profiling
Summary: Remove profiling hooks when not profiling
Status: RESOLVED DUPLICATE of bug 21735
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks: 20812
  Show dependency treegraph
 
Reported: 2008-10-01 23:18 PDT by Cameron Zwarich (cpst)
Modified: 2008-11-24 17:09 PST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron Zwarich (cpst) 2008-10-01 23:18:27 PDT
We currently always emit profiling hooks, even when we are not profiling. This adds unnecessary branches to function calls and returns. The solution is to regenerate code when profiling is enabled.

Geoff has already done some preliminary work in this direction in bug 21281.
Comment 1 Cameron Zwarich (cpst) 2008-10-02 15:33:57 PDT
Removing all branches (both the profiling branch and the activation / 'arguments' branch) from op_ret is at least a 4.3% speedup on Richards and a 1.0% speedup on DeltaBlue.
Comment 2 Cameron Zwarich (cpst) 2008-11-24 17:09:40 PST

*** This bug has been marked as a duplicate of 21735 ***