Bug 217107 – Fix EXT_color_buffer_half_float on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[James Darpinian]

Fix EXT_color_buffer_half_float on iOS

[James Darpinian]

Created attachment 410058 [details]
Patch

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[James Darpinian]

*** Bug 216998 has been marked as a duplicate of this bug. ***

[Kenneth Russell]

Comment on attachment 410058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410058&action=review

Looks good; one small question. r+

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:296
> +            functions->hasExtension("GL_EXT_color_buffer_half_float"))

Should this be "hasGLESExtension" (here and upstream)?

[James Darpinian]

Created attachment 410061 [details]
Patch

[James Darpinian]

Comment on attachment 410058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410058&action=review

>> Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp:296
>> +            functions->hasExtension("GL_EXT_color_buffer_half_float"))
> 
> Should this be "hasGLESExtension" (here and upstream)?

Sure, it doesn't make a difference here because the GLES check is redundant to the one in isAtLeastGLES, but it makes sense to be consistent.

[EWS]

Committed r267770: <https://trac.webkit.org/changeset/267770>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410061 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69768975>

[Thomas Kranz]

As of iOS/iPadOS 14.4, this does not seem to be fixed for WebGL2 contexts. It DOES work with Safari on macOS. The extension is reported for WebGL on both platforms.

[Kenneth Russell]

The ANGLE backend for WebGL 2.0 hasn't shipped in Safari on iOS yet, I'm afraid.

As soon as WebGL 2.0 is enabled by default on iOS - no longer experimentally - this will work.

[Thomas Kranz]

Oops, please forgive my unattentive reading of the ticket. :(

I suppose we don't have a timeframe for the switch on iOS, do we?

[Kenneth Russell]

I'm afraid we don't.