Bug 216989 - Avoid having to call context.lazyInitialize() in every AudioNode factory function
Summary: Avoid having to call context.lazyInitialize() in every AudioNode factory func...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 216988
Blocks: 212611 216994
  Show dependency treegraph
 
Reported: 2020-09-25 13:06 PDT by Chris Dumez
Modified: 2020-09-25 17:03 PDT (History)
8 users (show)

See Also:


Attachments
Patch (17.65 KB, patch)
2020-09-25 13:12 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (17.35 KB, patch)
2020-09-25 16:12 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-25 13:06:22 PDT
Avoid having to call context.lazyInitialize() in every AudioNode factory function. Replace all these calls with a single one inside the AudioNode constructor.
Comment 1 Chris Dumez 2020-09-25 13:12:33 PDT
Created attachment 409728 [details]
Patch
Comment 2 Chris Dumez 2020-09-25 16:12:44 PDT
Created attachment 409755 [details]
Patch
Comment 3 Darin Adler 2020-09-25 16:30:09 PDT
Comment on attachment 409728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409728&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233
> +    if (!isOfflineContext())
> +        ++s_hardwareContextCount;

Change log doesn’t mention this change.
Comment 4 Chris Dumez 2020-09-25 16:31:22 PDT
(In reply to Darin Adler from comment #3)
> Comment on attachment 409728 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409728&action=review
> 
> > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233
> > +    if (!isOfflineContext())
> > +        ++s_hardwareContextCount;
> 
> Change log doesn’t mention this change.

Yes, this was a left over change I did not mean to upload. This is why I uploaded another iteration.
Comment 5 EWS 2020-09-25 17:02:03 PDT
Committed r267609: <https://trac.webkit.org/changeset/267609>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409755 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-25 17:03:17 PDT
<rdar://problem/69601798>