Bug 216989 – Avoid having to call context.lazyInitialize() in every AudioNode factory function

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Chris Dumez]

Avoid having to call context.lazyInitialize() in every AudioNode factory function. Replace all these calls with a single one inside the AudioNode constructor.

[Chris Dumez]

Created attachment 409728 [details]
Patch

[Chris Dumez]

Created attachment 409755 [details]
Patch

[Darin Adler]

Comment on attachment 409728 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409728&action=review

> Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233
> +    if (!isOfflineContext())
> +        ++s_hardwareContextCount;

Change log doesn’t mention this change.

[Chris Dumez]

(In reply to Darin Adler from comment #3)
> Comment on attachment 409728 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409728&action=review
> 
> > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:233
> > +    if (!isOfflineContext())
> > +        ++s_hardwareContextCount;
> 
> Change log doesn’t mention this change.

Yes, this was a left over change I did not mean to upload. This is why I uploaded another iteration.

[EWS]

Committed r267609: <https://trac.webkit.org/changeset/267609>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409755 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69601798>