RESOLVED FIXED 216988
Drop AudioNode::setNodeType() 
https://bugs.webkit.org/show_bug.cgi?id=216988
Summary Drop AudioNode::setNodeType()
Chris Dumez
Reported 2020-09-25 12:53:01 PDT
Drop AudioNode::setNodeType() in favor of passing the NodeType to the AudioNode constructor. This makes sure we never forget to set the type.
Attachments
Patch (37.63 KB, patch)
2020-09-25 13:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (37.68 KB, patch)
2020-09-25 13:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-09-25 13:00:10 PDT
Created attachment 409725 [details] Patch
Chris Dumez
Comment 2 2020-09-25 13:10:47 PDT
Created attachment 409727 [details] Patch
Eric Carlson
Comment 3 2020-09-25 15:57:00 PDT
Comment on attachment 409727 [details] Patch rs=me
Chris Dumez
Comment 4 2020-09-25 16:03:07 PDT
Comment on attachment 409727 [details] Patch Clearing flags on attachment: 409727 Committed r267604: <https://trac.webkit.org/changeset/267604>
Chris Dumez
Comment 5 2020-09-25 16:03:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-09-25 16:04:20 PDT
<rdar://problem/69599144>
Note You need to log in before you can comment on or make changes to this bug.