Bug 216988 - Drop AudioNode::setNodeType()
Summary: Drop AudioNode::setNodeType()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Blocks: 212611 216989
  Show dependency treegraph
Reported: 2020-09-25 12:53 PDT by Chris Dumez
Modified: 2020-09-25 16:04 PDT (History)
9 users (show)

See Also:

Patch (37.63 KB, patch)
2020-09-25 13:00 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (37.68 KB, patch)
2020-09-25 13:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-25 12:53:01 PDT
Drop AudioNode::setNodeType() in favor of passing the NodeType to the AudioNode constructor. This makes sure we never forget to set the type.
Comment 1 Chris Dumez 2020-09-25 13:00:10 PDT
Created attachment 409725 [details]
Comment 2 Chris Dumez 2020-09-25 13:10:47 PDT
Created attachment 409727 [details]
Comment 3 Eric Carlson 2020-09-25 15:57:00 PDT
Comment on attachment 409727 [details]

Comment 4 Chris Dumez 2020-09-25 16:03:07 PDT
Comment on attachment 409727 [details]

Clearing flags on attachment: 409727

Committed r267604: <https://trac.webkit.org/changeset/267604>
Comment 5 Chris Dumez 2020-09-25 16:03:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-09-25 16:04:20 PDT