Simplify SVGTests.hasExtension idl by removing optional and default parameter. Skipping the parameter will now result in the parameter being a null string, which gives the same behaviour as before as the method just checks against non null namespaces. [1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension
Created attachment 409720 [details] Patch
Committed r267590: <https://trac.webkit.org/changeset/267590> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409720 [details].
<rdar://problem/69590625>
SVGTests.hasExtension and SVGTests.requiredFeatures were removed in SVG2. Specs link: https://www.w3.org/TR/SVG2/types.html#InterfaceSVGTests WebKit bugs to remove hasExtension and requiredFeatures: https://bugs.webkit.org/show_bug.cgi?id=198652 https://bugs.webkit.org/show_bug.cgi?id=204125 Chrome bug to remove requiredFeatures: https://bugzilla.mozilla.org/show_bug.cgi?id=1295404 Chrome bug to remove hasExtension: https://bugs.chromium.org/p/chromium/issues/detail?id=532405
(In reply to Said Abou-Hallawa from comment #4) > SVGTests.hasExtension and SVGTests.requiredFeatures were removed in SVG2. > > Specs link: > https://www.w3.org/TR/SVG2/types.html#InterfaceSVGTests > > WebKit bugs to remove hasExtension and requiredFeatures: > https://bugs.webkit.org/show_bug.cgi?id=198652 > https://bugs.webkit.org/show_bug.cgi?id=204125 > > Chrome bug to remove requiredFeatures: > https://bugzilla.mozilla.org/show_bug.cgi?id=1295404 > > Chrome bug to remove hasExtension: > https://bugs.chromium.org/p/chromium/issues/detail?id=532405 My main motivation is to remove the "Using "undefined" as default parameter value is wrong" FIXMEs, I'll continue to work on that. Is there anything left before removing these two methods? If not, I could work on that or review your patches.