Bug 204125 - [SVG2] Remove requiredFeatures and hasExtension from SVGTests
Summary: [SVG2] Remove requiredFeatures and hasExtension from SVGTests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: WebExposed
: 198652 (view as bug list)
Depends on:
Blocks: 191292 200143
  Show dependency treegraph
 
Reported: 2019-11-12 12:58 PST by Said Abou-Hallawa
Modified: 2021-08-09 00:31 PDT (History)
20 users (show)

See Also:


Attachments
Patch (209.53 KB, patch)
2019-11-12 13:43 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (221.77 KB, patch)
2019-11-12 16:23 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews213 for win-future (14.78 MB, application/zip)
2019-11-12 19:09 PST, EWS Watchlist
no flags Details
Patch (218.19 KB, patch)
2019-11-13 13:42 PST, Said Abou-Hallawa
sabouhallawa: review?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-11-12 12:58:20 PST
The link to the spec is: https://www.w3.org/TR/SVG/types.html#InterfaceSVGTests.
Comment 1 Said Abou-Hallawa 2019-11-12 13:43:32 PST
Created attachment 383376 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-11-12 16:23:24 PST
Created attachment 383400 [details]
Patch
Comment 3 EWS Watchlist 2019-11-12 16:24:41 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 EWS Watchlist 2019-11-12 19:09:11 PST
Comment on attachment 383400 [details]
Patch

Attachment 383400 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13244682

New failing tests:
svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg
Comment 5 EWS Watchlist 2019-11-12 19:09:14 PST
Created attachment 383421 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 6 Said Abou-Hallawa 2019-11-13 13:42:49 PST
Created attachment 383490 [details]
Patch
Comment 7 Frédéric Wang (:fredw) 2020-01-20 11:01:19 PST
@Said: Thanks for working on this! I think some Ryosuke and maybe others had concerns about this behavior change (see bug 198652 and https://lists.webkit.org/pipermail/webkit-dev/2019-June/030659.html ). Can you explain what's the status of the discussion here?
Comment 8 Ryosuke Niwa 2020-09-25 16:40:14 PDT
Comment on attachment 383490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=383490&action=review

> Source/WebCore/ChangeLog:8
> +        Remove these methods from SVGTests and fix the layout tests accordingly.

How do we know this change is safe to make?
We should probably put this under a runtime flag instead until we've successfully shipped it.
Comment 9 Frédéric Wang (:fredw) 2021-08-09 00:31:04 PDT
*** Bug 198652 has been marked as a duplicate of this bug. ***