Bug 216898 - [build.webkit.org] Add unit-test to detect invalid triggers in config.json
Summary: [build.webkit.org] Add unit-test to detect invalid triggers in config.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-23 14:40 PDT by Aakash Jain
Modified: 2020-09-29 09:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2020-09-29 06:40 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (4.79 KB, patch)
2020-09-29 07:04 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-09-23 14:40:38 PDT 
[build.webkit.org] We should add unit-test to detect invalid triggers in config.json, especially when the builder which is being triggered by the trigger doesn't exist.
Comment 1 Aakash Jain 2020-09-29 06:39:26 PDT 
This is to prevent issues like https://bugs.webkit.org/show_bug.cgi?id=216658#c15
Comment 2 Aakash Jain 2020-09-29 06:40:12 PDT 
Turns out that we don't have any unit-test for build.webkit.org for testing config.json
Comment 3 Aakash Jain 2020-09-29 06:40:33 PDT 
Created attachment 409994 [details]
Patch
Comment 4 Aakash Jain 2020-09-29 06:45:51 PDT 
(In reply to Aakash Jain from comment #3)
> Created attachment 409994 [details]
> Patch
This is mostly copied from https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py 
Long term aim is to have almost same unit-tests testing both EWS and build.webkit.org, but that would need various changes (especially because of different Buildbot versions) and would be done incrementally.
Comment 5 Aakash Jain 2020-09-29 07:04:19 PDT 
Created attachment 409996 [details]
Patch
Comment 6 EWS 2020-09-29 09:02:13 PDT 
Committed r267736: <https://trac.webkit.org/changeset/267736>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409996 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-29 09:03:18 PDT 
<rdar://problem/69749470>