Bug 216658 – Update iOS, watchOS and tvOS builders and tester with new SDKs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Matt Lewis]

The New SDKs and OSs have been released for iOS, watchOS, and tvOS. We need to update them on the builders and testers.

[Radar WebKit Bug Importer]

<rdar://problem/69084503>

[Matt Lewis]

Created attachment 409058 [details]
Patch

[Aakash Jain]

Comment on attachment 409058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409058&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:212
> +                      "name": "Apple iOS 14 Release (Build)", "type": "Build", "builddir": "ios-13-release",

Let's follow the new Buildbot naming convention and keep all these builder names without spaces and symbols (except - and _). This would help when we upgrade the Buildbot.

[Jonathan Bedard]

Comment on attachment 409058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409058&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:214
> +table.queue-grid tr.platform.watchos-simulator-7 img.logo {

Don't see the watchOS images?

[Matt Lewis]

(In reply to Aakash Jain from comment #3)
> Comment on attachment 409058 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409058&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:212
> > +                      "name": "Apple iOS 14 Release (Build)", "type": "Build", "builddir": "ios-13-release",
> 
> Let's follow the new Buildbot naming convention and keep all these builder
> names without spaces and symbols (except - and _). This would help when we
> upgrade the Buildbot.

Was just going with the way we had it currently, but I can make the changes.

[Matt Lewis]

(In reply to Jonathan Bedard from comment #4)
> Comment on attachment 409058 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409058&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:214
> > +table.queue-grid tr.platform.watchos-simulator-7 img.logo {
> 
> Don't see the watchOS images?

Hmmm... must have missed them in the upload

[Matt Lewis]

Created attachment 409405 [details]
Patch

[Aakash Jain]

Comment on attachment 409405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409405&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:229
> +                      "name": "Apple-iOS-14-Simulator-Release-WK2-(Tests)", "type": "TestAllButJSC", "builddir": "ios-simulator-14-release-tests-wk2",

Please remove the bracket in builder name here.

[Jonathan Bedard]

Comment on attachment 409405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409405&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:221
> +    content: -webkit-image-set(url(../Images/[e-mail]) 2x, url(../Images/WatchOS7.png) 1x);

Still don't see a watch here?

[Matt Lewis]

Created attachment 409433 [details]
Patch

[Matt Lewis]

Created attachment 409435 [details]
Patch

[Jonathan Bedard]

Comment on attachment 409435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409435&action=review

Patch looks good, but have we verified that we build with new SDKs? I know we did about a month ago, but I haven't verified we still do recently.

> Tools/ChangeLog:37
> [phone]  Matt Lewis  <[e-mail]>

Doubled changelog

> Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:68
> +                         set(['2 new passes', '3 flakes', '1 missing results', '1 failures']))

Was the increased indent deliberate?

[Matt Lewis]

(In reply to Jonathan Bedard from comment #12)
> Comment on attachment 409435 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409435&action=review
> 
> Patch looks good, but have we verified that we build with new SDKs? I know
> we did about a month ago, but I haven't verified we still do recently.
> 
> > Tools/ChangeLog:37
> > [phone]  Matt Lewis  <[e-mail]>
> 
> Doubled changelog
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:68
> > +                         set(['2 new passes', '3 flakes', '1 missing results', '1 failures']))
> 
> Was the increased indent deliberate?

No, that was the PEP8 auto formatter. Fixing.

[Matt Lewis]

Created attachment 409495 [details]
Patch

[Aakash Jain]

Comment on attachment 409495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409495&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:545
> +                      "builderNames": ["Apple iOS 14 Release (Build)"]

These builder-names also need to be updated (removing space and brackets).
Ideally unit-test should have failed because of this issue (a trigger triggering non-existing builder). I filed https://bugs.webkit.org/show_bug.cgi?id=216898 to add such unit-test.

[Matt Lewis]

Somehow (In reply to Aakash Jain from comment #15)
> Comment on attachment 409495 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409495&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:545
> > +                      "builderNames": ["Apple iOS 14 Release (Build)"]
> 
> These builder-names also need to be updated (removing space and brackets).
> Ideally unit-test should have failed because of this issue (a trigger
> triggering non-existing builder). I filed
> https://bugs.webkit.org/show_bug.cgi?id=216898 to add such unit-test.

Thanks for catching that. I guess my find and replacing failed me...

[Matt Lewis]

Created attachment 409505 [details]
Patch

[Aakash Jain]

Comment on attachment 409505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409505&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:572
> +                      "builderNames": ["AppleâiPadOS-14-Simulator-Release-WK2-Tests"]

AppleâiPadOS

[Matt Lewis]

(In reply to Aakash Jain from comment #18)
> Comment on attachment 409505 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409505&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:572
> > +                      "builderNames": ["AppleâiPadOS-14-Simulator-Release-WK2-Tests"]
> 
> AppleâiPadOS

weird.... I haven't changed anything locally and that is not what is there.

[Matt Lewis]

Created attachment 409510 [details]
Patch

[Jonathan Bedard]

Comment on attachment 409510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409510&action=review

Make sure we resolve the weird. character, though.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:572
> +                      "builderNames": ["AppleâiPadOS-14-Simulator-Release-WK2-Tests"]

Bugzilla review does badly with unicode characters,  that's what this is telling you.

[Matt Lewis]

Committed r267510: <https://trac.webkit.org/changeset/267510>