Bug 216875 - Root node with stateless wheel event is not always canHandleWheelEvent
Summary: Root node with stateless wheel event is not always canHandleWheelEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-23 06:12 PDT by cathiechen
Modified: 2020-09-24 05:53 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2020-09-23 06:17 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (1.82 KB, patch)
2020-09-24 01:27 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2020-09-23 06:12:23 PDT 
This bug is split from bug 216609
Comment 1 cathiechen 2020-09-23 06:17:39 PDT 
Created attachment 409468 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-23 13:13:17 PDT 
Comment on attachment 409468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148
> +    if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone)))

This should use isNonGestureEvent()
Comment 3 cathiechen 2020-09-24 01:26:36 PDT 
Comment on attachment 409468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review

>> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148
>> +    if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone)))
> 
> This should use isNonGestureEvent()

Done, thanks!
Comment 4 cathiechen 2020-09-24 01:27:43 PDT 
Created attachment 409540 [details]
Patch
Comment 5 EWS 2020-09-24 05:52:40 PDT 
Committed r267527: <https://trac.webkit.org/changeset/267527>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409540 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-24 05:53:18 PDT 
<rdar://problem/69498046>